Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: third_party/WebKit/Source/modules/fetch/Request.cpp

Issue 2777943005: [Bindings] Move and remove some private symbols from V8HiddenValue (Closed)
Patch Set: Fix test failures Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/Request.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Request.cpp b/third_party/WebKit/Source/modules/fetch/Request.cpp
index 7b710403a4381dfe5dbdc89e7fc27dfa779a39ae..14ad2a628526cc19a14d0c0cd522d9c4bd32a0e2 100644
--- a/third_party/WebKit/Source/modules/fetch/Request.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Request.cpp
@@ -5,6 +5,7 @@
#include "modules/fetch/Request.h"
#include "bindings/core/v8/Dictionary.h"
+#include "bindings/core/v8/V8PrivateProperty.h"
#include "core/dom/Document.h"
#include "core/dom/ExecutionContext.h"
#include "core/loader/ThreadableLoader.h"
@@ -717,7 +718,6 @@ String Request::mimeType() const {
}
void Request::refreshBody(ScriptState* scriptState) {
- v8::Local<v8::Value> bodyBuffer = ToV8(this->bodyBuffer(), scriptState);
v8::Local<v8::Value> request = ToV8(this, scriptState);
if (request.IsEmpty()) {
// |toV8| can return an empty handle when the worker is terminating.
@@ -727,9 +727,9 @@ void Request::refreshBody(ScriptState* scriptState) {
return;
}
DCHECK(request->IsObject());
- V8HiddenValue::setHiddenValue(
- scriptState, request.As<v8::Object>(),
- V8HiddenValue::internalBodyBuffer(scriptState->isolate()), bodyBuffer);
+ v8::Local<v8::Value> bodyBuffer = ToV8(this->bodyBuffer(), scriptState);
+ V8PrivateProperty::getInternalBodyBuffer(scriptState->isolate())
+ .set(request.As<v8::Object>(), bodyBuffer);
}
DEFINE_TRACE(Request) {

Powered by Google App Engine
This is Rietveld 408576698