Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2777903008: Removed deprecated WebVR functionality (Closed)

Created:
3 years, 8 months ago by bajones
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, feature-vr-reviews_chromium.org, blink-reviews, darin (slow to review), blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed deprecated WebVR functionality BUG=706561 Review-Url: https://codereview.chromium.org/2777903008 Cr-Commit-Position: refs/heads/master@{#461914} Committed: https://chromium.googlesource.com/chromium/src/+/c1d1aee5dcc8f13668fc418d5d670dc280759531

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed up tests #

Patch Set 3 : Rebase, fixed another test baseline #

Patch Set 4 : Another test re-baseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -353 lines) Patch
M chrome/browser/android/vr_shell/non_presenting_gvr_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/non_presenting_gvr_delegate.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M device/vr/test/fake_vr_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/vr/test/fake_vr_device.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M device/vr/vr_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/vr/vr_display_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/vr/vr_display_impl.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M device/vr/vr_service.mojom View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/webvr/idlharness.html View 1 5 chunks +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/webvr/idlharness-expected.txt View 1 2 3 5 chunks +1 line, -15 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/external/wpt/webvr/idlharness-expected.txt View 1 5 chunks +1 line, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/getPose_noupdate.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/getPose_oneframeupdate.html View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/getPose_samewithinframe.html View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 2 3 chunks +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.idl View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRFieldOfView.h View 1 chunk +1 line, -5 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRFieldOfView.idl View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 29 (14 generated)
bajones
dcheng@: Could you please review the use counter and .mojom changes? bsheedy@: Please review changes ...
3 years, 8 months ago (2017-03-29 22:09:02 UTC) #4
bsheedy
There's also the WPT IDL test in third_party/WebKit/LayoutTests/external/wpt/webvr/ that needs to be changed. Have you ...
3 years, 8 months ago (2017-03-29 22:19:56 UTC) #5
bajones
On 2017/03/29 22:19:56, bsheedy wrote: > There's also the WPT IDL test in > third_party/WebKit/LayoutTests/external/wpt/webvr/ ...
3 years, 8 months ago (2017-03-29 23:05:36 UTC) #6
bshe
On 2017/03/29 23:05:36, bajones wrote: > On 2017/03/29 22:19:56, bsheedy wrote: > > There's also ...
3 years, 8 months ago (2017-03-30 00:25:40 UTC) #7
dcheng
rs lgtm for the mojo and usecounter changes
3 years, 8 months ago (2017-03-30 00:30:48 UTC) #8
bsheedy
LayoutTests lgtm
3 years, 8 months ago (2017-03-30 00:32:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777903008/20001
3 years, 8 months ago (2017-03-30 04:36:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398408)
3 years, 8 months ago (2017-03-30 04:44:54 UTC) #13
haraken
On 2017/03/30 04:44:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-03-30 05:07:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777903008/20001
3 years, 8 months ago (2017-03-30 15:03:51 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/418427)
3 years, 8 months ago (2017-03-30 16:33:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777903008/40001
3 years, 8 months ago (2017-04-03 22:23:25 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/420859)
3 years, 8 months ago (2017-04-04 00:41:21 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777903008/60001
3 years, 8 months ago (2017-04-04 20:06:32 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 00:30:02 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c1d1aee5dcc8f13668fc418d5d67...

Powered by Google App Engine
This is Rietveld 408576698