Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8665)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.h

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: address nit from stgao@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.h b/chrome/test/chromedriver/chrome/chrome_impl.h
index d98cf6462a71ddeb6b47983995d271379ab15b01..906418aed5c972d2f401caf9a9af3d79f0d53eda 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_impl.h
@@ -8,10 +8,10 @@
#include <list>
#include <memory>
#include <string>
+#include <vector>
#include "base/compiler_specific.h"
#include "base/memory/linked_ptr.h"
-#include "base/memory/scoped_vector.h"
#include "chrome/test/chromedriver/chrome/chrome.h"
struct BrowserInfo;
@@ -47,7 +47,8 @@ class ChromeImpl : public Chrome {
protected:
ChromeImpl(std::unique_ptr<DevToolsHttpClient> http_client,
std::unique_ptr<DevToolsClient> websocket_client,
- ScopedVector<DevToolsEventListener>& devtools_event_listeners,
+ std::vector<std::unique_ptr<DevToolsEventListener>>
+ devtools_event_listeners,
std::unique_ptr<PortReservation> port_reservation,
std::string page_load_strategy);
@@ -64,7 +65,7 @@ class ChromeImpl : public Chrome {
// Web views in this list are in the same order as they are opened.
WebViewList web_views_;
- ScopedVector<DevToolsEventListener> devtools_event_listeners_;
+ std::vector<std::unique_ptr<DevToolsEventListener>> devtools_event_listeners_;
std::unique_ptr<PortReservation> port_reservation_;
std::string page_load_strategy_;
};
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.cc ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698