Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: address nit from stgao@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index c6f843e7248da15778dad9de09bf9199f24a68c2..c2deb622d93b0e9a6eaa1a767a3b944cfab39926 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -18,6 +18,7 @@
#include "build/build_config.h"
#include "chrome/test/chromedriver/chrome/automation_extension.h"
#include "chrome/test/chromedriver/chrome/devtools_client.h"
+#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
#include "chrome/test/chromedriver/chrome/devtools_http_client.h"
#include "chrome/test/chromedriver/chrome/status.h"
#include "chrome/test/chromedriver/chrome/web_view_impl.h"
@@ -73,7 +74,8 @@ bool KillProcess(const base::Process& process, bool kill_gracefully) {
ChromeDesktopImpl::ChromeDesktopImpl(
std::unique_ptr<DevToolsHttpClient> http_client,
std::unique_ptr<DevToolsClient> websocket_client,
- ScopedVector<DevToolsEventListener>& devtools_event_listeners,
+ std::vector<std::unique_ptr<DevToolsEventListener>>
+ devtools_event_listeners,
std::unique_ptr<PortReservation> port_reservation,
std::string page_load_strategy,
base::Process process,
@@ -83,7 +85,7 @@ ChromeDesktopImpl::ChromeDesktopImpl(
bool network_emulation_enabled)
: ChromeImpl(std::move(http_client),
std::move(websocket_client),
- devtools_event_listeners,
+ std::move(devtools_event_listeners),
std::move(port_reservation),
page_load_strategy),
process_(std::move(process)),
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698