Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10527)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.h

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.h b/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
index e5a2b1d80448f0503514d3a11925c0d7fbcb014d..ec679c70d81a5d2acb802f346b2234fc188c3349 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
@@ -7,6 +7,7 @@
#include <memory>
#include <string>
+#include <vector>
#include "base/command_line.h"
#include "base/compiler_specific.h"
@@ -26,17 +27,17 @@ class WebView;
class ChromeDesktopImpl : public ChromeImpl {
public:
- ChromeDesktopImpl(
- std::unique_ptr<DevToolsHttpClient> http_client,
- std::unique_ptr<DevToolsClient> websocket_client,
- ScopedVector<DevToolsEventListener>& devtools_event_listeners,
- std::unique_ptr<PortReservation> port_reservation,
- std::string page_load_strategy,
- base::Process process,
- const base::CommandLine& command,
- base::ScopedTempDir* user_data_dir,
- base::ScopedTempDir* extension_dir,
- bool network_emulation_enabled);
+ ChromeDesktopImpl(std::unique_ptr<DevToolsHttpClient> http_client,
+ std::unique_ptr<DevToolsClient> websocket_client,
+ std::vector<std::unique_ptr<DevToolsEventListener>>&
+ devtools_event_listeners,
Avi (use Gerrit) 2017/03/29 03:26:55 etc
leonhsl(Using Gerrit) 2017/03/29 09:22:30 Done.
+ std::unique_ptr<PortReservation> port_reservation,
+ std::string page_load_strategy,
+ base::Process process,
+ const base::CommandLine& command,
+ base::ScopedTempDir* user_data_dir,
+ base::ScopedTempDir* extension_dir,
+ bool network_emulation_enabled);
~ChromeDesktopImpl() override;
// Waits for a page with the given URL to appear and finish loading.

Powered by Google App Engine
This is Rietveld 408576698