Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6881)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/chrome/chrome_android_impl.cc

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/chromedriver/chrome/chrome_android_impl.h ('K') | « chrome/test/chromedriver/chrome/chrome_android_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.h » ('j') | chrome/test/chromedriver/chrome/chrome_desktop_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/chrome_android_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_android_impl.cc b/chrome/test/chromedriver/chrome/chrome_android_impl.cc
index 83c4213f9ae8709f067a49a16e3c7e444558aa89..4a050671b413e21d21ac7b8f7e967a52823958fc 100644
--- a/chrome/test/chromedriver/chrome/chrome_android_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_android_impl.cc
@@ -16,7 +16,8 @@
ChromeAndroidImpl::ChromeAndroidImpl(
std::unique_ptr<DevToolsHttpClient> http_client,
std::unique_ptr<DevToolsClient> websocket_client,
- ScopedVector<DevToolsEventListener>& devtools_event_listeners,
+ std::vector<std::unique_ptr<DevToolsEventListener>>&
+ devtools_event_listeners,
Avi (use Gerrit) 2017/03/29 03:26:55 ditto
leonhsl(Using Gerrit) 2017/03/29 09:22:30 Done.
std::unique_ptr<PortReservation> port_reservation,
std::string page_load_strategy,
std::unique_ptr<Device> device)
« chrome/test/chromedriver/chrome/chrome_android_impl.h ('K') | « chrome/test/chromedriver/chrome/chrome_android_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.h » ('j') | chrome/test/chromedriver/chrome/chrome_desktop_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698