Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: chrome/test/chromedriver/chrome/chrome_android_impl.h

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_android_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_android_impl.h b/chrome/test/chromedriver/chrome/chrome_android_impl.h
index f7564b0b50cf0b18d296094ef350a608c597d505..a8815a2e77efee9d52ac9432ecfc3d786657bcb5 100644
--- a/chrome/test/chromedriver/chrome/chrome_android_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_android_impl.h
@@ -7,6 +7,7 @@
#include <memory>
#include <string>
+#include <vector>
#include "base/compiler_specific.h"
#include "chrome/test/chromedriver/chrome/chrome_impl.h"
@@ -17,13 +18,13 @@ class DevToolsHttpClient;
class ChromeAndroidImpl : public ChromeImpl {
public:
- ChromeAndroidImpl(
- std::unique_ptr<DevToolsHttpClient> http_client,
- std::unique_ptr<DevToolsClient> websocket_client,
- ScopedVector<DevToolsEventListener>& devtools_event_listeners,
- std::unique_ptr<PortReservation> port_reservation,
- std::string page_load_strategy,
- std::unique_ptr<Device> device);
+ ChromeAndroidImpl(std::unique_ptr<DevToolsHttpClient> http_client,
+ std::unique_ptr<DevToolsClient> websocket_client,
+ std::vector<std::unique_ptr<DevToolsEventListener>>&
Avi (use Gerrit) 2017/03/29 03:26:55 BTW this is in violation of the style guide (no no
leonhsl(Using Gerrit) 2017/03/29 09:22:30 Done.
+ devtools_event_listeners,
+ std::unique_ptr<PortReservation> port_reservation,
+ std::string page_load_strategy,
+ std::unique_ptr<Device> device);
~ChromeAndroidImpl() override;
// Overridden from Chrome:

Powered by Google App Engine
This is Rietveld 408576698