Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2777883002: Remove Fasta's copy of accessors.dart. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
jensj, asgerf
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update Rasta in dart2js. #

Patch Set 3 : Remove type checking of Rasta, not strong mode clean. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -804 lines) Patch
M pkg/analyzer/lib/src/kernel/ast_from_analyzer.dart View 7 chunks +12 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/kernel/accessors.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 14 chunks +34 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 11 chunks +68 lines, -46 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart View 32 chunks +198 lines, -155 lines 0 comments Download
D pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 1 chunk +0 lines, -495 lines 0 comments Download
M pkg/front_end/lib/src/fasta/names.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/kernel/lib/frontend/accessors.dart View 21 chunks +133 lines, -61 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/context.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/kernel/lib/transformations/closure/converter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/kernel/lib/transformations/closure/mock.dart View 5 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ahe
https://codereview.chromium.org/2777883002/diff/1/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart File pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart (right): https://codereview.chromium.org/2777883002/diff/1/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart#newcode63 pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart:63: abstract class BuilderAccessor implements Accessor { I'll rename this ...
3 years, 9 months ago (2017-03-27 10:47:26 UTC) #2
asgerf
LGTM
3 years, 9 months ago (2017-03-27 10:50:22 UTC) #3
ahe
Also modified dart2js, PTAL.
3 years, 9 months ago (2017-03-27 11:13:32 UTC) #4
asgerf
Still LGTM
3 years, 9 months ago (2017-03-27 11:16:43 UTC) #5
jensj
lgtm
3 years, 9 months ago (2017-03-27 11:26:51 UTC) #6
ahe
3 years, 9 months ago (2017-03-27 12:04:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
02573b3caa1f13f68b5c5921b35e4e2e4ca62ab9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698