Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2278)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_visitor.dart

Issue 2777883002: Remove Fasta's copy of accessors.dart. (Closed)
Patch Set: Remove type checking of Rasta, not strong mode clean. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | pkg/front_end/lib/src/fasta/kernel/body_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/kernel_visitor.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_visitor.dart b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
index b889af3c53f77481eb3fa1f1badf50f868307146..a6527127585450b157f93c07ab48f721fe2ae4e9 100644
--- a/pkg/compiler/lib/src/kernel/kernel_visitor.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
@@ -494,7 +494,8 @@ class KernelVisitor extends Object
}
return new StaticAccessor(
(getter == null) ? null : kernel.elementToIr(getter),
- (setter == null) ? null : kernel.elementToIr(setter));
+ (setter == null) ? null : kernel.elementToIr(setter),
+ ir.TreeNode.noOffset);
}
Accessor computeAccessor(ForIn node, Element element) {
@@ -514,15 +515,16 @@ class KernelVisitor extends Object
return buildStaticAccessor(null);
} else if (element.isGetter) {
if (element.isInstanceMember) {
- return new ThisPropertyAccessor(
- kernel.irName(element.name, element), null, null);
+ return new ThisPropertyAccessor(kernel.irName(element.name, element),
+ null, null, ir.TreeNode.noOffset);
} else {
GetterElement getter = element;
Element setter = getter.setter;
return buildStaticAccessor(getter, setter);
}
} else if (element.isLocal) {
- return new VariableAccessor(getLocal(element));
+ return new VariableAccessor(
+ getLocal(element), null, ir.TreeNode.noOffset);
} else if (element.isField) {
return buildStaticAccessor(element);
} else {
@@ -1264,7 +1266,8 @@ class KernelVisitor extends Object
}
ir.Expression buildTypeLiteralSet(TypeConstantExpression constant, Node rhs) {
- return new ReadOnlyAccessor(buildTypeLiteral(constant))
+ return new ReadOnlyAccessor(
+ buildTypeLiteral(constant), ir.TreeNode.noOffset)
.buildAssignment(visitForValue(rhs), voidContext: isVoidContext);
}
@@ -1374,7 +1377,7 @@ class KernelVisitor extends Object
Send node, Node receiver, Name name, Node rhs, _) {
ir.Name irName = nameToIrName(name);
Accessor accessor = (receiver == null)
- ? new ThisPropertyAccessor(irName, null, null)
+ ? new ThisPropertyAccessor(irName, null, null, ir.TreeNode.noOffset)
: PropertyAccessor.make(visitForValue(receiver), irName, null, null);
return _finishSetIfNull(node, accessor, rhs);
}
@@ -1576,8 +1579,8 @@ class KernelVisitor extends Object
}
Accessor buildNullAwarePropertyAccessor(Node receiver, Name name) {
- return new NullAwarePropertyAccessor(
- visitForValue(receiver), nameToIrName(name), null, null, null);
+ return new NullAwarePropertyAccessor(visitForValue(receiver),
+ nameToIrName(name), null, null, null, ir.TreeNode.noOffset);
}
@override
@@ -1855,8 +1858,10 @@ class KernelVisitor extends Object
ir.Expression handleLocalCompounds(
SendSet node, LocalElement local, CompoundRhs rhs, _,
{bool isSetterValid}) {
- ir.Expression compound =
- buildCompound(new VariableAccessor(getLocal(local)), rhs, node);
+ ir.Expression compound = buildCompound(
+ new VariableAccessor(getLocal(local), null, ir.TreeNode.noOffset),
+ rhs,
+ node);
if (compound is ir.VariableSet) {
associateNode(compound.value, node);
} else {
@@ -1958,7 +1963,8 @@ class KernelVisitor extends Object
ir.Expression handleLocalSetIfNulls(
SendSet node, LocalElement local, Node rhs, _,
{bool isSetterValid}) {
- return _finishSetIfNull(node, new VariableAccessor(getLocal(local)), rhs);
+ return _finishSetIfNull(node,
+ new VariableAccessor(getLocal(local), null, ir.TreeNode.noOffset), rhs);
}
@override
@@ -2438,7 +2444,9 @@ class KernelVisitor extends Object
ir.Expression handleTypeLiteralConstantCompounds(
SendSet node, ConstantExpression constant, CompoundRhs rhs, _) {
return buildCompound(
- new ReadOnlyAccessor(buildTypeLiteral(constant)), rhs, node);
+ new ReadOnlyAccessor(buildTypeLiteral(constant), ir.TreeNode.noOffset),
+ rhs,
+ node);
}
ir.TypeLiteral buildTypeVariable(TypeVariableElement element) {
@@ -2449,7 +2457,9 @@ class KernelVisitor extends Object
ir.Expression handleTypeVariableTypeLiteralCompounds(
SendSet node, TypeVariableElement element, CompoundRhs rhs, _) {
return buildCompound(
- new ReadOnlyAccessor(buildTypeVariable(element)), rhs, node);
+ new ReadOnlyAccessor(buildTypeVariable(element), ir.TreeNode.noOffset),
+ rhs,
+ node);
}
@override
@@ -2483,7 +2493,8 @@ class KernelVisitor extends Object
return new SuperPropertyAccessor(
kernel.irName(element.name, element),
(getter == null) ? null : kernel.elementToIr(getter),
- (setter == null) ? null : kernel.elementToIr(setter));
+ (setter == null) ? null : kernel.elementToIr(setter),
+ ir.TreeNode.noOffset);
}
Accessor buildSuperIndexAccessor(Expression index, Element getter,
@@ -2497,7 +2508,8 @@ class KernelVisitor extends Object
return new SuperIndexAccessor(
visitForValue(index),
(getter == null) ? null : kernel.elementToIr(getter),
- (setter == null) ? null : kernel.elementToIr(setter));
+ (setter == null) ? null : kernel.elementToIr(setter),
+ ir.TreeNode.noOffset);
}
@override
@@ -2665,7 +2677,8 @@ class KernelVisitor extends Object
}
Accessor buildThisPropertyAccessor(Name name) {
- return new ThisPropertyAccessor(nameToIrName(name), null, null);
+ return new ThisPropertyAccessor(
+ nameToIrName(name), null, null, ir.TreeNode.noOffset);
}
@override
@@ -2772,7 +2785,8 @@ class KernelVisitor extends Object
@override
ir.Expression visitTypeVariableTypeLiteralSet(
SendSet node, TypeVariableElement element, Node rhs, _) {
- return new ReadOnlyAccessor(buildTypeVariable(element))
+ return new ReadOnlyAccessor(
+ buildTypeVariable(element), ir.TreeNode.noOffset)
.buildAssignment(visitForValue(rhs), voidContext: isVoidContext);
}
@@ -2780,7 +2794,9 @@ class KernelVisitor extends Object
ir.Expression visitTypeVariableTypeLiteralSetIfNull(
Send node, TypeVariableElement element, Node rhs, _) {
return _finishSetIfNull(
- node, new ReadOnlyAccessor(buildTypeVariable(element)), rhs);
+ node,
+ new ReadOnlyAccessor(buildTypeVariable(element), ir.TreeNode.noOffset),
+ rhs);
}
@override
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | pkg/front_end/lib/src/fasta/kernel/body_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698