Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2777863003: [InputEvent] Distinguish between soft line and hard line (Closed)

Created:
3 years, 9 months ago by chongz
Modified:
3 years, 8 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Distinguish between soft line and hard line This CL adds input types DeleteSoftLineForward/Backward for line boundary and DeleteHardLineForward/Backward for paragraph boundary. BUG=705641 Review-Url: https://codereview.chromium.org/2777863003 Cr-Commit-Position: refs/heads/master@{#460404} Committed: https://chromium.googlesource.com/chromium/src/+/e7727c85ef1e113d274a9328d93c4ef196e2fa7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-cancelable.html View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
chongz
yosin@ PTAL, thanks!
3 years, 9 months ago (2017-03-27 21:54:13 UTC) #8
yosin_UTC9
lgtm
3 years, 8 months ago (2017-03-28 07:06:43 UTC) #9
chongz
tkent@ PTAL at "InputEvent.h/cc", thanks!
3 years, 8 months ago (2017-03-28 20:43:35 UTC) #11
tkent
lgtm
3 years, 8 months ago (2017-03-28 22:25:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777863003/1
3 years, 8 months ago (2017-03-29 14:35:52 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 16:06:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7727c85ef1e113d274a9328d93c...

Powered by Google App Engine
This is Rietveld 408576698