Generalize the usage of referrer chain

Generalize the usage of referrer chain

Change a couple of things to generalize the scope of referrer chain usage:
(1) Rename proto enum field from DOWNLOD_URL to EVENT_URL
   -- google3 end change landed
(2) Rename functions in SafeBrowsingNavigationObserverManager class
(3) Revise comments in
   c/b/safe_browsing/safe_browsing_navigation_observer*.

BUG=706100
Review-Url: https://codereview.chromium.org/2777853005
Cr-Commit-Position: refs/heads/master@{#460653}
Committed: https://chromium.googlesource.com/chromium/src/+/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe

[Jialiu Lin, 2017-03-28 18:52:45]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 18:53:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 19:11:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:11:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jialiu Lin, 2017-03-28 19:56:18]

jialiul@chromium.org changed reviewers:
+ lpz@chromium.org

[Jialiu Lin, 2017-03-28 19:56:19]

Hi lpz@,
Could you take a look this CL? There is no functional change except renaming
functions, fields, and revising comments.

Thank you!

[lpz, 2017-03-29 13:46:27]

lgtm

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
(right):

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h:48: //
If navigation happened in the main frame, |target_url| and |target_main_
nit: |target_main_frame_url| to newline so it's not split?

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h:164:
AttributionResult IdentifyReferrerChainByWebContent(
nit: WebContents (with an s) to match content::WebContents

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_service.h (right):

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_service.h:344:
navigation_observer_manager_;
+indent on this line?

https://codereview.chromium.org/2777853005/diff/40001/components/safe_browsin...
File components/safe_browsing/csd.proto (right):

https://codereview.chromium.org/2777853005/diff/40001/components/safe_browsin...
components/safe_browsing/csd.proto:509: EVENT_URL = 1;
"Event" is a little vague, perhaps some comments outlining what constitutes an
event?

[Jialiu Lin, 2017-03-29 20:40:00]

Thanks for your quick review! :-)

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
(right):

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h:48: //
If navigation happened in the main frame, |target_url| and |target_main_
On 2017/03/29 at 13:46:27, lpz wrote:
> nit: |target_main_frame_url| to newline so it's not split?

Done.

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h:164:
AttributionResult IdentifyReferrerChainByWebContent(
On 2017/03/29 at 13:46:26, lpz wrote:
> nit: WebContents (with an s) to match content::WebContents

Ah, thanks for catching this. Done.

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_service.h (right):

https://codereview.chromium.org/2777853005/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_service.h:344:
navigation_observer_manager_;
On 2017/03/29 at 13:46:27, lpz wrote:
> +indent on this line?
Done.

https://codereview.chromium.org/2777853005/diff/40001/components/safe_browsin...
File components/safe_browsing/csd.proto (right):

https://codereview.chromium.org/2777853005/diff/40001/components/safe_browsin...
components/safe_browsing/csd.proto:509: EVENT_URL = 1;
On 2017/03/29 at 13:46:27, lpz wrote:
> "Event" is a little vague, perhaps some comments outlining what constitutes an
event?

Done.

[Jialiu Lin, 2017-03-29 23:46:16]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2017-03-29 23:46:17]

The patchset sent to the CQ was uploaded after l-g-t-m from lpz@chromium.org
Link to the patchset: https://codereview.chromium.org/2777853005/#ps60001
(title: "address lpz's comments")

[commit-bot: I haz the power, 2017-03-29 23:47:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 01:01:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:01:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jialiu Lin, 2017-03-30 01:36:33]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:37:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 01:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:49:22]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[Jialiu Lin, 2017-03-30 03:26:35]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2017-03-30 03:27:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 03:54:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490844395406870,
"parent_rev": "9dede133389c377cc53eff4fd50d6a220318d882", "commit_rev":
"bfe0492224665ab6ce8dd8588dcfb474fb27fdbe"}

[commit-bot: I haz the power, 2017-03-30 03:55:07]

Description was changed from

==========
Generalize the usage of referrer chain

Change a couple of things to generalize the scope of referrer chain usage:
(1) Rename proto enum field from DOWNLOD_URL to EVENT_URL
   -- google3 end change landed
(2) Rename functions in SafeBrowsingNavigationObserverManager class
(3) Revise comments in
   c/b/safe_browsing/safe_browsing_navigation_observer*.

BUG=706100
==========

to

==========
Generalize the usage of referrer chain

Change a couple of things to generalize the scope of referrer chain usage:
(1) Rename proto enum field from DOWNLOD_URL to EVENT_URL
   -- google3 end change landed
(2) Rename functions in SafeBrowsingNavigationObserverManager class
(3) Revise comments in
   c/b/safe_browsing/safe_browsing_navigation_observer*.

BUG=706100

Review-Url: https://codereview.chromium.org/2777853005
Cr-Commit-Position: refs/heads/master@{#460653}
Committed:
https://chromium.googlesource.com/chromium/src/+/bfe0492224665ab6ce8dd8588dcf...
==========

[commit-bot: I haz the power, 2017-03-30 03:55:09]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bfe0492224665ab6ce8dd8588dcf...