Bypass DRP if a redirect cycle is detected

components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/metrics/field_trial.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate_test_utils.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers_test_utils.h"
 #include "net/http/http_response_headers.h"
 #include "net/proxy/proxy_service.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
 
 namespace data_reduction_proxy {
 
 class DataReductionProxyHeadersTest : public testing::Test {
  protected:
   void SetUp() override {
     storage_delegate_.reset(new TestDataReductionProxyEventStorageDelegate());
     event_creator_.reset(
         new DataReductionProxyEventCreator(storage_delegate_.get()));
   }
@@ skipping 730 matching lines @@
     scoped_refptr<net::HttpResponseHeaders> parsed(
         new net::HttpResponseHeaders(headers));
     DataReductionProxyInfo chrome_proxy_info;
 
     base::FieldTrialList trial_list(nullptr);
     base::FieldTrialList::CreateFieldTrial(
         "DataReductionProxyServerExperiments",
         tests[i].in_tamper_detection_experiment ? "TamperDetection_Enabled"
                                                 : "TamperDetection_Disabled");
 
-    EXPECT_EQ(tests[i].expected_result, GetDataReductionProxyBypassType(
-                                            parsed.get(), &chrome_proxy_info));
+    EXPECT_EQ(tests[i].expected_result,
+              GetDataReductionProxyBypassType(std::vector<GURL>(), *parsed,
+                                              &chrome_proxy_info));
   }
 }
 
+TEST_F(DataReductionProxyHeadersTest,
+       GetDataReductionProxyBypassEventTypeURLRedirectCycle) {
+  const struct {
+    const char* headers;
+    std::vector<GURL> url_chain;
+    DataReductionProxyBypassType expected_result;
+  } tests[] = {
+      {
+          "HTTP/1.1 200 OK\n"
+          "Via: 1.1 Chrome-Compression-Proxy\n",
+          std::vector<GURL>{GURL("http://google.com/1"),
+                            GURL("http://google.com/2"),
+                            GURL("http://google.com/1")},
+          BYPASS_EVENT_TYPE_URL_REDIRECT_CYCLE,
+      },
+      {
+          "HTTP/1.1 200 OK\n"
+          "Via: 1.1 Chrome-Compression-Proxy\n",
+          std::vector<GURL>{
+              GURL("http://google.com/1"), GURL("http://google.com/2"),
+              GURL("http://google.com/1"), GURL("http://google.com/2")},
+          BYPASS_EVENT_TYPE_URL_REDIRECT_CYCLE,
+      },
+      {
+          "HTTP/1.1 200 OK\n"
+          "Via: 1.1 Chrome-Compression-Proxy\n",
+          std::vector<GURL>{GURL("http://google.com/1")}, BYPASS_EVENT_TYPE_MAX,
+      },
+      {
+          "HTTP/1.1 200 OK\n"
+          "Via: 1.1 Chrome-Compression-Proxy\n",
+          std::vector<GURL>{GURL("http://google.com/1"),
+                            GURL("http://google.com/2")},
+          BYPASS_EVENT_TYPE_MAX,
+      },
+      {
+          "HTTP/1.1 200 OK\n"
+          "Via: 1.1 Chrome-Compression-Proxy\n",
+          std::vector<GURL>{GURL("http://google.com/1"),
+                            GURL("http://google.com/2"),
+                            GURL("http://google.com/3")},
+          BYPASS_EVENT_TYPE_MAX,
+      },
+      {
+          "HTTP/1.1 200 OK\n"
+          "Via: 1.1 Chrome-Compression-Proxy\n",
+          std::vector<GURL>{
+              GURL("http://google.com/1"), GURL("http://google.com/2"),
+              GURL("http://google.com/3"), GURL("http://google.com/1")},
+          BYPASS_EVENT_TYPE_URL_REDIRECT_CYCLE,
+      },
+      {
+          "HTTP/1.1 200 OK\n"
+          "Via: 1.1 Chrome-Compression-Proxy\n",
+          std::vector<GURL>(), BYPASS_EVENT_TYPE_MAX,
+      }};
+
+  for (const auto& test : tests) {
+    std::string headers(test.headers);
+    HeadersToRaw(&headers);
+    scoped_refptr<net::HttpResponseHeaders> parsed(
+        new net::HttpResponseHeaders(headers));
+    DataReductionProxyInfo chrome_proxy_info;
+
+    EXPECT_EQ(test.expected_result,
+              GetDataReductionProxyBypassType(test.url_chain, *parsed,
+                                              &chrome_proxy_info));
+  }
+}
+
 TEST_F(DataReductionProxyHeadersTest,
        GetDataReductionProxyActionFingerprintChromeProxy) {
   const struct {
      std::string label;
      const char* headers;
      bool expected_fingerprint_exist;
      std::string expected_fingerprint;
   } tests[] = {
     { "fingerprint doesn't exist",
       "HTTP/1.1 200 OK\n"
@@ skipping 224 matching lines @@
     std::string output_values_string;
     for (size_t j = 0; j < output_values.size(); ++j)
       output_values_string += output_values[j] + ",";
 
     EXPECT_EQ(test[i].expected_output_values_string, output_values_string)
         << test[i].label;
   }
 }
 
 }  // namespace data_reduction_proxy