Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2777823002: Bypass DRP if a redirect cycle is detected (Closed)

Created:
3 years, 9 months ago by tbansal1
Modified:
3 years, 8 months ago
Reviewers:
RyanSturm, rkaplow
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Bypass DRP if a redirect cycle is detected If a redirect cycle is detected, Data Reduction Proxy (DRP) is bypassed for the current request. BUG=664586 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2777823002 Cr-Commit-Position: refs/heads/master@{#460656} Committed: https://chromium.googlesource.com/chromium/src/+/412c3e37d5e70522d3ff5a0961c58a1f624d3ef7

Patch Set 1 : ps #

Total comments: 6

Patch Set 2 : ryansturm comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -49 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc View 1 4 chunks +10 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc View 1 4 chunks +84 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc View 2 chunks +59 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_bypass_type_list.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h View 1 3 chunks +8 lines, -6 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc View 1 10 chunks +40 lines, -19 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc View 1 5 chunks +87 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 44 (34 generated)
tbansal1
ryansturm: ptal. Thanks.
3 years, 9 months ago (2017-03-27 17:23:37 UTC) #16
RyanSturm
https://codereview.chromium.org/2777823002/diff/90001/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc (right): https://codereview.chromium.org/2777823002/diff/90001/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc#newcode340 components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:340: std::unique_ptr<net::URLRequest> CreateAndExecuteURLRedirectCycleRequest() { This is a really good test. ...
3 years, 8 months ago (2017-03-28 18:03:19 UTC) #21
tbansal1
ryansturm: ptal. Thanks. https://codereview.chromium.org/2777823002/diff/90001/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc (right): https://codereview.chromium.org/2777823002/diff/90001/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc#newcode340 components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:340: std::unique_ptr<net::URLRequest> CreateAndExecuteURLRedirectCycleRequest() { On 2017/03/28 18:03:19, ...
3 years, 8 months ago (2017-03-28 19:59:49 UTC) #23
RyanSturm
lgtm
3 years, 8 months ago (2017-03-29 21:45:10 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777823002/130001
3 years, 8 months ago (2017-03-29 21:47:26 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398010)
3 years, 8 months ago (2017-03-29 22:00:06 UTC) #36
tbansal1
rkaplow: ptal at histograms.xml. Thanks.
3 years, 8 months ago (2017-03-29 22:01:35 UTC) #38
rkaplow
lgtm
3 years, 8 months ago (2017-03-30 01:28:54 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777823002/130001
3 years, 8 months ago (2017-03-30 01:45:09 UTC) #41
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 04:01:13 UTC) #44
Message was sent while issue was closed.
Committed patchset #2 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/412c3e37d5e70522d3ff5a0961c5...

Powered by Google App Engine
This is Rietveld 408576698