Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2777813003: Fix mobile user agent string not being used when PlzNavigate is enabled. (Closed)

Created:
3 years, 8 months ago by jam
Modified:
3 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mobile user agent string not being used when PlzNavigate is enabled. The user agent override string should only have been used when the NavigationEntry has the flag set. BUG=705218 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2777813003 Cr-Commit-Position: refs/heads/master@{#459895} Committed: https://chromium.googlesource.com/chromium/src/+/d83b035e1cb466ff77c52973fe633fe780833325

Patch Set 1 #

Patch Set 2 : without PlzNavigate and with test #

Total comments: 2

Patch Set 3 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -2 lines) Patch
M content/browser/frame_host/navigation_request.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 2 3 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
jam
3 years, 8 months ago (2017-03-27 18:56:39 UTC) #7
nasko
LGTM with one note. https://codereview.chromium.org/2777813003/diff/20001/content/browser/web_contents/web_contents_impl_browsertest.cc File content/browser/web_contents/web_contents_impl_browsertest.cc (right): https://codereview.chromium.org/2777813003/diff/20001/content/browser/web_contents/web_contents_impl_browsertest.cc#newcode1468 content/browser/web_contents/web_contents_impl_browsertest.cc:1468: .GetActiveEntry() GetLastCommittedEntry(), GetActiveEntry is deprecated ...
3 years, 8 months ago (2017-03-27 19:52:31 UTC) #9
jam
https://codereview.chromium.org/2777813003/diff/20001/content/browser/web_contents/web_contents_impl_browsertest.cc File content/browser/web_contents/web_contents_impl_browsertest.cc (right): https://codereview.chromium.org/2777813003/diff/20001/content/browser/web_contents/web_contents_impl_browsertest.cc#newcode1468 content/browser/web_contents/web_contents_impl_browsertest.cc:1468: .GetActiveEntry() On 2017/03/27 19:52:31, nasko wrote: > GetLastCommittedEntry(), GetActiveEntry ...
3 years, 8 months ago (2017-03-27 20:00:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777813003/40001
3 years, 8 months ago (2017-03-27 20:01:18 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-27 21:58:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d83b035e1cb466ff77c52973fe63...

Powered by Google App Engine
This is Rietveld 408576698