Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2777793002: Refactored out need to use CSSPropertyID to parse counter properties. (Closed)

Created:
3 years, 9 months ago by Bugs Nash
Modified:
3 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored out need to use CSSPropertyID to parse counter properties. Refactored out the need to use CSSPropertyID in the parsing logic of the CSSPropertyCounterIncrement and CSSPropertyCounterReset properties. This is pre work to allow the parseSingleValue method of these properties to be implemented in their property APIs. BUG=668012 Review-Url: https://codereview.chromium.org/2777793002 Cr-Commit-Position: refs/heads/master@{#459709} Committed: https://chromium.googlesource.com/chromium/src/+/24acb2c9fcaeef8e5b30b82e5b2fdaa9396353c7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 13 (8 generated)
Bugs Nash
3 years, 9 months ago (2017-03-27 04:20:34 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 9 months ago (2017-03-27 04:25:43 UTC) #5
suzyh_UTC10 (ex-contributor)
https://codereview.chromium.org/2777793002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/2777793002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1867 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1867: return consumeCounter(m_range, 1); These magic numbers should be replaced ...
3 years, 9 months ago (2017-03-27 04:29:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777793002/1
3 years, 9 months ago (2017-03-27 04:53:15 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 06:44:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24acb2c9fcaeef8e5b30b82e5b2f...

Powered by Google App Engine
This is Rietveld 408576698