chrome/android/java/res/drawable/tabular_context_menu_image_border.xml - Issue 2777773002: Show the image header for the Context Menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/drawable/tabular_context_menu_image_border.xml

Issue 2777773002: Show the image header for the Context Menu (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/drawable/checkerboard_background.xml ('K') | « chrome/android/java/res/drawable/checkerboard_background.xml ('k') | chrome/android/java/res/layout/tabular_context_menu_page.xml » ('j') | chrome/android/java/res/layout/tabular_context_menu_page.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/drawable/tabular_context_menu_image_border.xml

diff --git a/chrome/android/java/res/drawable/tabular_context_menu_image_border.xml b/chrome/android/java/res/drawable/tabular_context_menu_image_border.xml

new file mode 100644

index 0000000000000000000000000000000000000000..edaf01749c6aa3061ca1c5ba5a965e9f46023fc8

--- /dev/null

+++ b/chrome/android/java/res/drawable/tabular_context_menu_image_border.xml

@@ -0,0 +1,9 @@

+<?xml version="1.0" encoding="utf-8"?>

+ Use of this source code is governed by a BSD-style license that can be

+ found in the LICENSE file. -->

+<shape xmlns:android="http://schemas.android.com/apk/res/android"

+ android:shape="rectangle">

+ <stroke android:width="1dp"

+ android:color="@color/google_grey_400"/>

Theresa 2017/03/27 18:28:26 nit: does this fit on the line above?

JJ 2017/03/27 20:47:12 It does? I thought it was one line per attribute?

Theresa 2017/03/28 17:23:08 Typically it is, but our shapes defined in XML are

JJ 2017/03/28 23:19:20 Interesting. Done!

+</shape>