chrome/android/java/res/drawable/tabular_context_menu_image_border.xml - Issue 2777773002: Show the image header for the Context Menu

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/tabular_context_menu_image_border.xml

Issue 2777773002: Show the image header for the Context Menu (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5 <shape xmlns:android="http://schemas.android.com/apk/res/android"

	6 android:shape="rectangle">

	7 <stroke android:width="1dp"

	8 android:color="@color/google_grey_400"/>
	Theresa 2017/03/27 18:28:26 nit: does this fit on the line above? nit: does this fit on the line above? JJ 2017/03/27 20:47:12 It does? I thought it was one line per attribute? Show quoted text On 2017/03/27 18:28:26, Theresa wrote: > nit: does this fit on the line above? It does? I thought it was one line per attribute? Theresa 2017/03/28 17:23:08 Typically it is, but our shapes defined in XML are Show quoted text On 2017/03/27 20:47:12, JJ wrote: > On 2017/03/27 18:28:26, Theresa wrote: > > nit: does this fit on the line above? > > It does? I thought it was one line per attribute? Typically it is, but our shapes defined in XML are a notable exception in the code base. JJ 2017/03/28 23:19:20 Interesting. Done! Show quoted text On 2017/03/28 17:23:08, Theresa wrote: > On 2017/03/27 20:47:12, JJ wrote: > > On 2017/03/27 18:28:26, Theresa wrote: > > > nit: does this fit on the line above? > > > > It does? I thought it was one line per attribute? > > Typically it is, but our shapes defined in XML are a notable exception in the > code base. Interesting. Done!
	9 </shape>

OLD	NEW