Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2777643002: Add VS 2017 toolchain hash (Closed)

Created:
3 years, 9 months ago by brucedawson
Modified:
3 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add VS 2017 toolchain hash This change adds a hash for the VS 2017 RTM toolchain download in depot tools. This allows Googlers to use VS 2017 to build Chrome without needing to install it, and lets build machines use VS 2017 (although they continue to default to VS 2015. The package was created on a Windows Server 2016 VM. One would hope that the OS used wouldn't matter, but ...? Previous installs of VS 2015 or the platform SDK are likely to leave files lying around that will alter the hash so a clean VM is needed. Then follow these steps: Install VS 2017 Professional RTM, selecting the "Desktop development with C++" component, and add the MFC and ATL support option. After this is done you need to install the debugger packages from the Windows 10 SDK. Go to: https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk and be sure to check the Debugging Tools option. Once the installers have downloaded you can find the x86 and x64 debugger installers in the download directory in "Windows Kits\10\StandaloneSDK\Installers" - run them both. Then run the packaging script, like this: > python depot_tools\win_toolchain\package_from_installed.py 2017 Note that this packages the 10.0.14393.0 SDK, but this is not the same 10.0.14393.0 SDK that was used in the previous VS 2015 packaging. The SDK was updated without changing the version number. Most of the changes should not matter, but be aware. To use this package set these two environment variables: DEPOT_TOOLS_WIN_TOOLCHAIN=1 GYP_MSVS_VERSION=2017 Then run "gclient runhooks" to download the new package. The .ninja files will not automatically update so you may need to run gn gen on your output directories. The 'chrome' target should build cleanly without warnings. However VS 2017 is not yet a supported toolchain so warnings may appear. You may want to use the treat_warnings_as_errors = false build flag. To run VS 2017 tests on the buildbots you need to change the CURRENT_DEFAULT_TOOLCHAIN_VERSION in build\vs_toolchain.py to '2017' and you need to add a landmine to force a rebuild. The build process was tested on two separate VMs to ensure that the results were consistent. They were. BUG=683729 Review-Url: https://codereview.chromium.org/2777643002 Cr-Commit-Position: refs/heads/master@{#459593} Committed: https://chromium.googlesource.com/chromium/src/+/560bb951d9a6625633fcad4e4168fb7054bb4dfa

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/vs_toolchain.py View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
brucedawson
PTAL. This change has no effect on the buildbots because the VS 2015 toolchain continues ...
3 years, 9 months ago (2017-03-24 22:40:20 UTC) #3
scottmg
lgtm https://codereview.chromium.org/2777643002/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/2777643002/diff/1/build/vs_toolchain.py#newcode350 build/vs_toolchain.py:350: if env_version == '2013': deleeeeeeete me!
3 years, 9 months ago (2017-03-24 22:42:17 UTC) #4
brucedawson
I'll put together a second CL for deleting 2013.
3 years, 9 months ago (2017-03-24 22:44:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777643002/1
3 years, 9 months ago (2017-03-24 22:45:08 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 23:10:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/560bb951d9a6625633fcad4e4168...

Powered by Google App Engine
This is Rietveld 408576698