Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2777633002: DevTools: add bindings tests to fixate shadowDOM behavior. (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add bindings tests to fixate shadowDOM behavior. This patch adds two tests to fixate our handling of ShadowDOM in bindings and navigator. - shadowdom-bindings.html - illustrates shadowDOM handling by varioius bindings - shadowdom-navigator.html - illustrates navigator behavior The shadowdom-bindings.html shows the root cause of the problem which we have in crbug.com/671867. BUG=671867, 670180 R=dgozman Review-Url: https://codereview.chromium.org/2777633002 Cr-Commit-Position: refs/heads/master@{#459883} Committed: https://chromium.googlesource.com/chromium/src/+/051c8e924b31fc3939604392284bfe2ff8e15361

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-24 20:06:10 UTC) #1
dgozman
lgtm
3 years, 9 months ago (2017-03-27 16:37:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777633002/1
3 years, 9 months ago (2017-03-27 17:40:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/67147)
3 years, 9 months ago (2017-03-27 18:08:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777633002/1
3 years, 9 months ago (2017-03-27 21:10:45 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 21:23:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/051c8e924b31fc3939604392284b...

Powered by Google App Engine
This is Rietveld 408576698