Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2777503002: [MD Bookmarks] Deselect items when clicking outside the bookmark card. (Closed)

Created:
3 years, 9 months ago by calamity
Modified:
3 years, 8 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Deselect items when clicking outside the bookmark card. BUG=699214 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2777503002 Cr-Commit-Position: refs/heads/master@{#461612} Committed: https://chromium.googlesource.com/chromium/src/+/f5a2ecc6e12c815fd95fc234a6055c1fc81069ad

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M chrome/browser/resources/md_bookmarks/actions.js View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.js View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/reducers.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/list_test.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/reducers_test.js View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
calamity
3 years, 9 months ago (2017-03-24 04:20:01 UTC) #4
tsergeant
lgtm
3 years, 9 months ago (2017-03-27 05:24:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777503002/60001
3 years, 8 months ago (2017-04-03 06:02:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/341058)
3 years, 8 months ago (2017-04-03 09:07:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777503002/60001
3 years, 8 months ago (2017-04-04 00:37:30 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 01:57:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f5a2ecc6e12c815fd95fc234a605...

Powered by Google App Engine
This is Rietveld 408576698