Pref service: Add initial support for pref registration.

services/preferences/pref_store_manager_impl.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/preferences/pref_store_manager_impl.h"
 
 #include <utility>
 
 #include "base/memory/ref_counted.h"
 #include "base/threading/sequenced_worker_pool.h"
+#include "components/prefs/default_pref_store.h"
 #include "components/prefs/pref_value_store.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
 #include "services/preferences/persistent_pref_store_factory.h"
 #include "services/preferences/persistent_pref_store_impl.h"
+#include "services/preferences/public/cpp/pref_store_impl.h"
 #include "services/service_manager/public/cpp/interface_registry.h"
 
 namespace prefs {
 namespace {
 
 using ConnectCallback = mojom::PrefStoreConnector::ConnectCallback;
 using PrefStorePtrs =
     std::unordered_map<PrefValueStore::PrefStoreType, mojom::PrefStorePtr>;
 
 // Used to make sure all pref stores have been registered before replying to any
@@ skipping 36 matching lines @@
     const PrefStorePtrs& pref_store_ptrs,
     mojom::PersistentPrefStoreConnectionPtr persistent_pref_store_connection,
     const ConnectCallback& callback) {
   make_scoped_refptr(new ConnectionBarrier(
                          pref_store_ptrs,
                          std::move(persistent_pref_store_connection), callback))
       ->Init(pref_store_ptrs);
 }
 
 void ConnectionBarrier::Init(const PrefStorePtrs& pref_store_ptrs) {
-  if (expected_connections_ == 0) {
-    // Degenerate case. We don't expect this, but it could happen in
-    // e.g. testing.
-    callback_.Run(std::move(persistent_pref_store_connection_),
-                  std::move(connections_));
-    return;
-  }
   for (const auto& ptr : pref_store_ptrs) {
     ptr.second->AddObserver(
         base::Bind(&ConnectionBarrier::OnConnect, this, ptr.first));
   }
 }
 
 ConnectionBarrier::ConnectionBarrier(
     const PrefStorePtrs& pref_store_ptrs,
     mojom::PersistentPrefStoreConnectionPtr persistent_pref_store_connection,
     const ConnectCallback& callback)
@@ skipping 14 matching lines @@
   }
 }
 
 }  // namespace
 
 PrefStoreManagerImpl::PrefStoreManagerImpl(
     std::set<PrefValueStore::PrefStoreType> expected_pref_stores,
     scoped_refptr<base::SequencedWorkerPool> worker_pool)
     : expected_pref_stores_(std::move(expected_pref_stores)),
       init_binding_(this),
-      worker_pool_(std::move(worker_pool)) {}
+      defaults_(new DefaultPrefStore),
+      defaults_wrapper_(base::MakeUnique<PrefStoreImpl>(
+          defaults_,
+          mojo::MakeRequest(&pref_store_ptrs_[PrefValueStore::DEFAULT_STORE]))),
+      worker_pool_(std::move(worker_pool)) {
+  expected_pref_stores_.insert(PrefValueStore::DEFAULT_STORE);
+}
 
 PrefStoreManagerImpl::~PrefStoreManagerImpl() = default;
 
 void PrefStoreManagerImpl::Register(PrefValueStore::PrefStoreType type,
                                     mojom::PrefStorePtr pref_store_ptr) {
   if (expected_pref_stores_.count(type) == 0) {
     LOG(WARNING) << "Not registering unexpected pref store: " << type;
     return;
   }
   DVLOG(1) << "Registering pref store: " << type;
   pref_store_ptr.set_connection_error_handler(
       base::Bind(&PrefStoreManagerImpl::OnPrefStoreDisconnect,
                  base::Unretained(this), type));
   const bool success =
       pref_store_ptrs_.insert(std::make_pair(type, std::move(pref_store_ptr)))
           .second;
   DCHECK(success) << "The same pref store registered twice: " << type;
   if (AllConnected()) {
     DVLOG(1) << "All pref stores registered.";
     ProcessPendingConnects();
   }
 }
 
-void PrefStoreManagerImpl::Connect(const ConnectCallback& callback) {
+void PrefStoreManagerImpl::Connect(mojom::PrefRegistryPtr pref_registry,
+                                   const ConnectCallback& callback) {
   if (AllConnected()) {
-    ConnectImpl(callback);
+    ConnectImpl(std::move(pref_registry), callback);
   } else {
-    pending_callbacks_.push_back(callback);
+    pending_connects_.push_back(
+        std::make_pair(callback, std::move(pref_registry)));
   }
 }
 
 void PrefStoreManagerImpl::Create(
     const service_manager::Identity& remote_identity,
     prefs::mojom::PrefStoreConnectorRequest request) {
   connector_bindings_.AddBinding(this, std::move(request));
 }
 
 void PrefStoreManagerImpl::Create(
@@ skipping 44 matching lines @@
   DVLOG(1) << "Deregistering pref store: " << type;
   pref_store_ptrs_.erase(type);
 }
 
 bool PrefStoreManagerImpl::AllConnected() const {
   return pref_store_ptrs_.size() == expected_pref_stores_.size() &&
          persistent_pref_store_ && persistent_pref_store_->initialized();
 }
 
 void PrefStoreManagerImpl::ProcessPendingConnects() {
-  for (auto& connect : pending_callbacks_)
-    ConnectImpl(connect);
-  pending_callbacks_.clear();
+  for (auto& connect : pending_connects_)
+    ConnectImpl(std::move(connect.second), connect.first);
+  pending_connects_.clear();
 }
 
-void PrefStoreManagerImpl::ConnectImpl(const ConnectCallback& callback) {
+void PrefStoreManagerImpl::ConnectImpl(mojom::PrefRegistryPtr pref_registry,
+                                       const ConnectCallback& callback) {
+  PersistentPrefStoreImpl::ObservedPrefs observed_prefs;
+  for (auto& registration : pref_registry->registrations) {
+    observed_prefs.insert(registration.first);
+    const auto& key = registration.first;
+    auto& default_value = registration.second->default_value;
+    const base::Value* old_default = nullptr;
+    // TODO(sammc): Once non-owning registrations are supported, disallow
+    // multiple owners instead of just checking for consistent defaults.
+    if (defaults_->GetValue(key, &old_default))
+      DCHECK(old_default->Equals(default_value.get()));
+    else
+      defaults_->SetDefaultValue(key, std::move(default_value));
+  }
   ConnectionBarrier::Create(
-      pref_store_ptrs_, persistent_pref_store_->CreateConnection(), callback);
+      pref_store_ptrs_,
+      persistent_pref_store_->CreateConnection(std::move(observed_prefs)),
+      callback);
 }
 
 void PrefStoreManagerImpl::OnPersistentPrefStoreReady() {
   DVLOG(1) << "PersistentPrefStore ready";
   if (AllConnected()) {
     ProcessPendingConnects();
   }
 }
 
 }  // namespace prefs