Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2777483002: Pref service: Add initial support for pref registration. (Closed)

Created:
3 years, 9 months ago by Sam McNally
Modified:
3 years, 8 months ago
Reviewers:
Martin Barbella, tibell
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pref service: Add initial support for pref registration. This: - Adds a mojo structs representing registrations to be passed to PrefStoreConnector::Connect calls. - Uses those registrarions to build a default pref store implemented inside the pref service. - Changes PersistentPrefStoreImpl to use registrations to filter observer notifications. BUG=654988 Review-Url: https://codereview.chromium.org/2777483002 Cr-Commit-Position: refs/heads/master@{#460267} Committed: https://chromium.googlesource.com/chromium/src/+/6926632bd1e7eb3a0cd62f34f0e9d546be86d8ed

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -45 lines) Patch
M services/preferences/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/preferences/persistent_pref_store_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M services/preferences/persistent_pref_store_impl.cc View 1 6 chunks +11 lines, -6 lines 0 comments Download
M services/preferences/persistent_pref_store_impl_unittest.cc View 3 chunks +35 lines, -3 lines 0 comments Download
M services/preferences/pref_service_factory_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M services/preferences/pref_store_manager_impl.h View 4 chunks +13 lines, -4 lines 0 comments Download
M services/preferences/pref_store_manager_impl.cc View 5 chunks +35 lines, -16 lines 0 comments Download
M services/preferences/public/cpp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/preferences/public/cpp/persistent_pref_store_client.h View 3 chunks +5 lines, -1 line 0 comments Download
M services/preferences/public/cpp/persistent_pref_store_client.cc View 3 chunks +12 lines, -5 lines 0 comments Download
A services/preferences/public/cpp/pref_registry_serializer.h View 1 chunk +18 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/pref_registry_serializer.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M services/preferences/public/cpp/pref_service_factory.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M services/preferences/public/interfaces/preferences.mojom View 1 2 chunks +17 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 53 (42 generated)
Sam McNally
3 years, 9 months ago (2017-03-24 05:14:07 UTC) #16
tibell
lgtm https://codereview.chromium.org/2777483002/diff/60001/services/preferences/persistent_pref_store_impl.cc File services/preferences/persistent_pref_store_impl.cc (right): https://codereview.chromium.org/2777483002/diff/60001/services/preferences/persistent_pref_store_impl.cc#newcode41 services/preferences/persistent_pref_store_impl.cc:41: if (!base::ContainsKey(observed_keys_, key)) Optional: merge with previous if? ...
3 years, 9 months ago (2017-03-26 22:54:47 UTC) #19
Sam McNally
+mbarbella for the mojom https://codereview.chromium.org/2777483002/diff/60001/services/preferences/persistent_pref_store_impl.cc File services/preferences/persistent_pref_store_impl.cc (right): https://codereview.chromium.org/2777483002/diff/60001/services/preferences/persistent_pref_store_impl.cc#newcode41 services/preferences/persistent_pref_store_impl.cc:41: if (!base::ContainsKey(observed_keys_, key)) On 2017/03/26 ...
3 years, 9 months ago (2017-03-26 23:02:45 UTC) #23
Martin Barbella
mojom lgtm
3 years, 8 months ago (2017-03-28 16:01:29 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777483002/100001
3 years, 8 months ago (2017-03-28 22:26:22 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/376962)
3 years, 8 months ago (2017-03-28 22:38:30 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777483002/100001
3 years, 8 months ago (2017-03-28 22:50:00 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777483002/100001
3 years, 8 months ago (2017-03-28 23:53:00 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/418563)
3 years, 8 months ago (2017-03-29 01:04:50 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777483002/100001
3 years, 8 months ago (2017-03-29 01:29:46 UTC) #50
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 03:31:35 UTC) #53
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6926632bd1e7eb3a0cd62f34f0e9...

Powered by Google App Engine
This is Rietveld 408576698