Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2777453002: Fix style of custom matcher in settings_egtest.mm. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 9 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix style of custom matcher in settings_egtest.mm. EarlGrey matchers are C-Style methods and should start with a capital letter in Chromium. BUG=680787 Review-Url: https://codereview.chromium.org/2777453002 Cr-Commit-Position: refs/heads/master@{#459315} Committed: https://chromium.googlesource.com/chromium/src/+/1bc7717c1d7ccf5a90464a3fdf38536fd24d7fa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/browser/ui/settings/settings_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
baxley
3 years, 9 months ago (2017-03-23 22:28:37 UTC) #2
lpromero
lgtm
3 years, 9 months ago (2017-03-24 00:10:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777453002/1
3 years, 9 months ago (2017-03-24 00:11:06 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 01:04:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bc7717c1d7ccf5a90464a3fdf38...

Powered by Google App Engine
This is Rietveld 408576698