Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2777443002: Use SameDocument instead of SamePage term for extensions. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SameDocument instead of SamePage term for extensions. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 Review-Url: https://codereview.chromium.org/2777443002 Cr-Commit-Position: refs/heads/master@{#459432} Committed: https://chromium.googlesource.com/chromium/src/+/f942ba0c142618d08df7eaab7619d61758cc8826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/test/data/web_view/apitest/guest_same_document_navigation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/test/data/web_view/apitest/guest_same_page_navigation.html View 1 chunk +0 lines, -17 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eugene But (OOO till 7-30)
PTAL
3 years, 9 months ago (2017-03-23 22:24:29 UTC) #3
Devlin
On 2017/03/23 22:24:29, Eugene But wrote: > PTAL lgtm % CL description nit: s/presumable/presumably
3 years, 9 months ago (2017-03-23 22:28:06 UTC) #5
Eugene But (OOO till 7-30)
Thanks for a quick review!
3 years, 9 months ago (2017-03-24 15:35:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777443002/1
3 years, 9 months ago (2017-03-24 15:35:41 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 15:42:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f942ba0c142618d08df7eaab7619...

Powered by Google App Engine
This is Rietveld 408576698