Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2777413003: Log foreground duration for failed provisional loads. (Closed)

Created:
3 years, 8 months ago by Bryan McQuade
Modified:
3 years, 8 months ago
Reviewers:
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Log foreground duration for failed provisional loads. UKM logs foreground duration for both committed and provisional loads. This change makes core UMA metrics more consistent with UKM. This metric will also help to measure the impact of the delayed navigation experiment, where we expect there to be an increased number of failed provisional loads. BUG=705058 NOTRY=true NOPRESUBMIT=true TBR=csharrison Review-Url: https://codereview.chromium.org/2771293002 Cr-Commit-Position: refs/heads/master@{#459576} (cherry picked from commit 8db499251a795b754dbef05b1d73a5e877001da8)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 7 chunks +24 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777413003/1
3 years, 8 months ago (2017-03-29 05:24:16 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 05:38:00 UTC) #6
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698