Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2777343006: [CrOS Tether] TetherHostFetcher: When invoking callbacks, use a copy of the device list. (Closed)

Created:
3 years, 8 months ago by Kyle Horimoto
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] TetherHostFetcher: When invoking callbacks, use a copy of the device list. Previously, it used a reference which had already been deleted. The single callback case correctly used the copy, but the list callback did not. BUG=672263 Review-Url: https://codereview.chromium.org/2777343006 Cr-Commit-Position: refs/heads/master@{#460445} Committed: https://chromium.googlesource.com/chromium/src/+/aea32ab18a36aa5bb829b3095e6ddd776bf62e67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chromeos/components/tether/tether_host_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Kyle Horimoto
3 years, 8 months ago (2017-03-29 00:21:11 UTC) #2
Ryan Hansberry
lgtm
3 years, 8 months ago (2017-03-29 17:02:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777343006/1
3 years, 8 months ago (2017-03-29 17:03:38 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-29 17:03:39 UTC) #7
Jeremy Klein
lgtm
3 years, 8 months ago (2017-03-29 17:07:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777343006/1
3 years, 8 months ago (2017-03-29 17:13:18 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:46:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aea32ab18a36aa5bb829b3095e6d...

Powered by Google App Engine
This is Rietveld 408576698