Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2777343005: MD Settings: minor cleanup for settings-input (Closed)

Created:
3 years, 8 months ago by scottchen
Modified:
3 years, 8 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: minor cleanup for settings-input As requested in 2766093002 after that CL landed. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2777343005 Cr-Commit-Position: refs/heads/master@{#460539} Committed: https://chromium.googlesource.com/chromium/src/+/6d55081498cd5e8a4c23137920e485d7be685d95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/resources/settings/controls/settings_input.js View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
scottchen
3 years, 8 months ago (2017-03-28 21:02:41 UTC) #4
dpapad
LGTM. Nit: I would probably rephrase "refactor" as "cleanup", and potentially mention the CL that ...
3 years, 8 months ago (2017-03-28 21:24:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777343005/1
3 years, 8 months ago (2017-03-29 17:56:36 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 21:14:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d55081498cd5e8a4c23137920e4...

Powered by Google App Engine
This is Rietveld 408576698