Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2777313002: Fix Cronet Android test after 755221e53 (Closed)

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, mikecase (-- gone --)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Cronet Android test after 755221e53 This test hardcodes a value from net/base/load_flags_list.h. :/ R=mmenke@chromium.org BUG=700568 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2777313002 Cr-Commit-Position: refs/heads/master@{#459892} Committed: https://chromium.googlesource.com/chromium/src/+/7d731649d58a6ac8994005e86371079807c91651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
scottmg
3 years, 9 months ago (2017-03-27 20:55:57 UTC) #3
mmenke
LGTM
3 years, 9 months ago (2017-03-27 20:57:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777313002/1
3 years, 9 months ago (2017-03-27 21:00:16 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 21:49:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d731649d58a6ac8994005e86371...

Powered by Google App Engine
This is Rietveld 408576698