Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2777283005: Add an experimental search widget (Closed)

Created:
3 years, 8 months ago by Yusuf
Modified:
3 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, srahim+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an experimental search widget Adds an experimental search widget to use the omnibox from Android Launcher. Review-Url: https://codereview.chromium.org/2777283005 Cr-Commit-Position: refs/heads/master@{#461575} Committed: https://chromium.googlesource.com/chromium/src/+/c92e401f8f0571b77b4a97a8af6376eb55912814

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Patch Set 3 : actually add renamed files #

Patch Set 4 : resource rename #

Patch Set 5 : got rid of assert #

Patch Set 6 : Moved initialize to FinishNativeInitialization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1136 lines, -0 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/search_widget_template.xml View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/search_widget_template_transparent.xml View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/android/java/res/xml/search_widget_info.xml View 1 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/searchwidget/BoxAnimatorScrim.java View 1 chunk +87 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java View 1 chunk +497 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchBoxDataProvider.java View 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchLocationBarLayout.java View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java View 1 5 1 chunk +281 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (19 generated)
Yusuf
3 years, 8 months ago (2017-03-28 17:34:54 UTC) #2
gone
lgtm we can clean up later https://codereview.chromium.org/2777283005/diff/1/chrome/android/java/res/layout/text_box_template.xml File chrome/android/java/res/layout/text_box_template.xml (right): https://codereview.chromium.org/2777283005/diff/1/chrome/android/java/res/layout/text_box_template.xml#newcode1 chrome/android/java/res/layout/text_box_template.xml:1: <?xml version="1.0" encoding="utf-8"?> ...
3 years, 8 months ago (2017-03-28 18:16:23 UTC) #3
Yusuf
https://codereview.chromium.org/2777283005/diff/1/chrome/android/java/res/layout/text_box_template.xml File chrome/android/java/res/layout/text_box_template.xml (right): https://codereview.chromium.org/2777283005/diff/1/chrome/android/java/res/layout/text_box_template.xml#newcode1 chrome/android/java/res/layout/text_box_template.xml:1: <?xml version="1.0" encoding="utf-8"?> On 2017/03/28 18:16:23, dfalcantara (load balance ...
3 years, 8 months ago (2017-03-28 20:03:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777283005/20001
3 years, 8 months ago (2017-03-28 20:03:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777283005/40001
3 years, 8 months ago (2017-03-28 20:11:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/237521)
3 years, 8 months ago (2017-03-28 20:35:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777283005/60001
3 years, 8 months ago (2017-03-30 20:47:02 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/147590)
3 years, 8 months ago (2017-03-30 23:11:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777283005/80001
3 years, 8 months ago (2017-03-31 23:01:12 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/148522) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 8 months ago (2017-04-01 00:11:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777283005/100001
3 years, 8 months ago (2017-04-03 17:39:44 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/263478)
3 years, 8 months ago (2017-04-03 20:46:52 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777283005/100001
3 years, 8 months ago (2017-04-03 20:55:43 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 23:24:35 UTC) #33
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c92e401f8f0571b77b4a97a8af63...

Powered by Google App Engine
This is Rietveld 408576698