Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2777233004: Using UrlConstants instead of hardcoded values in few places (Closed)

Created:
3 years, 8 months ago by marcin
Modified:
3 years, 8 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Using UrlConstants instead of hardcoded values in few places BUG= Review-Url: https://codereview.chromium.org/2777233004 Cr-Commit-Position: refs/heads/master@{#460478} Committed: https://chromium.googlesource.com/chromium/src/+/b032d00c1530480e08446ba7660a895c1d23c74e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
marcin
3 years, 8 months ago (2017-03-28 23:22:47 UTC) #3
gone
lgtm
3 years, 8 months ago (2017-03-29 18:11:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777233004/1
3 years, 8 months ago (2017-03-29 18:13:05 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:07:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b032d00c1530480e08446ba7660a...

Powered by Google App Engine
This is Rietveld 408576698