[Bindings] Replace V8HiddenValue with V8PrivateProperty in V0CustomElementConstructorBuilder

Replace V8HiddenValue in V0CustomElementConstructorBuilder with V8PrivateProperty 


BUG=611864
Review-Url: https://codereview.chromium.org/2777223005
Cr-Commit-Position: refs/heads/master@{#460135}
Committed: https://chromium.googlesource.com/chromium/src/+/037cd106d24d8205c8a076a18401bb849aa31508

[peria, 2017-03-28 12:00:56]

Description was changed from

==========
Remove V8HiddenValues in V0CustomElement

BUG=
==========

to

==========
Replace V8HiddenValues in V0CustomElementConstructorBuilder with
V8PrivateProperty 


BUG= 611864
==========

[peria, 2017-03-28 12:01:17]

Description was changed from

==========
Replace V8HiddenValues in V0CustomElementConstructorBuilder with
V8PrivateProperty 


BUG= 611864
==========

to

==========
Replace V8HiddenValue in V0CustomElementConstructorBuilder with
V8PrivateProperty 


BUG= 611864
==========

[peria, 2017-03-28 12:08:24]

peria@chromium.org changed reviewers:
+ haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-03-28 12:08:25]

PTL

This is a mechanical change.

[peria, 2017-03-28 12:08:30]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 12:08:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-03-28 12:29:11]

https://codereview.chromium.org/2777223005/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
(right):

https://codereview.chromium.org/2777223005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp:259:
.get(context, m_prototype)
You may want to revive V8PrivateProperty::Symbol::hasValue(), which is faster
than get().

[peria, 2017-03-28 12:57:18]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 12:57:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-03-28 12:57:49]

https://codereview.chromium.org/2777223005/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
(right):

https://codereview.chromium.org/2777223005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp:259:
.get(context, m_prototype)
On 2017/03/28 12:29:11, Yuki wrote:
> You may want to revive V8PrivateProperty::Symbol::hasValue(), which is faster
> than get().

Sounds good.
Reverted (http://crrev.com/2785473002)
and done.

[Yuki, 2017-03-28 13:02:55]

LGTM with a comment.

https://codereview.chromium.org/2777223005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
(right):

https://codereview.chromium.org/2777223005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp:259:
!V8PrivateProperty::getCustomElementIsInterfacePrototypeObject(isolate)
s/!//

[peria, 2017-03-28 13:14:16]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 13:14:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 15:12:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 15:12:58]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-03-28 15:57:50]

LGTM

[peria, 2017-03-28 16:08:33]

The CQ bit was checked by peria@chromium.org

[peria, 2017-03-28 16:08:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2777223005/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-03-28 16:09:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:55:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490717313578350,
"parent_rev": "ebb5e2e9291f37c82a8f121793ab1593d6beec9d", "commit_rev":
"037cd106d24d8205c8a076a18401bb849aa31508"}

[commit-bot: I haz the power, 2017-03-28 16:56:09]

Description was changed from

==========
Replace V8HiddenValue in V0CustomElementConstructorBuilder with
V8PrivateProperty 


BUG= 611864
==========

to

==========
Replace V8HiddenValue in V0CustomElementConstructorBuilder with
V8PrivateProperty 


BUG= 611864

Review-Url: https://codereview.chromium.org/2777223005
Cr-Commit-Position: refs/heads/master@{#460135}
Committed:
https://chromium.googlesource.com/chromium/src/+/037cd106d24d8205c8a076a18401...
==========

[commit-bot: I haz the power, 2017-03-28 16:56:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/037cd106d24d8205c8a076a18401...