Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2777223005: [Bindings] Replace V8HiddenValue with V8PrivateProperty in V0CustomElementConstructorBuilder (Closed)

Created:
3 years, 8 months ago by peria
Modified:
3 years, 8 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace V8HiddenValue in V0CustomElementConstructorBuilder with V8PrivateProperty BUG=611864 Review-Url: https://codereview.chromium.org/2777223005 Cr-Commit-Position: refs/heads/master@{#460135} Committed: https://chromium.googlesource.com/chromium/src/+/037cd106d24d8205c8a076a18401bb849aa31508

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use hasValue #

Total comments: 1

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -43 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp View 1 2 6 chunks +26 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 1 1 chunk +7 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
peria
PTL This is a mechanical change.
3 years, 8 months ago (2017-03-28 12:08:25 UTC) #4
Yuki
https://codereview.chromium.org/2777223005/diff/1/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp File third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp (right): https://codereview.chromium.org/2777223005/diff/1/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp#newcode259 third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp:259: .get(context, m_prototype) You may want to revive V8PrivateProperty::Symbol::hasValue(), which ...
3 years, 8 months ago (2017-03-28 12:29:11 UTC) #7
peria
https://codereview.chromium.org/2777223005/diff/1/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp File third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp (right): https://codereview.chromium.org/2777223005/diff/1/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp#newcode259 third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp:259: .get(context, m_prototype) On 2017/03/28 12:29:11, Yuki wrote: > You ...
3 years, 8 months ago (2017-03-28 12:57:49 UTC) #10
Yuki
LGTM with a comment. https://codereview.chromium.org/2777223005/diff/20001/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp File third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp (right): https://codereview.chromium.org/2777223005/diff/20001/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp#newcode259 third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp:259: !V8PrivateProperty::getCustomElementIsInterfacePrototypeObject(isolate) s/!//
3 years, 8 months ago (2017-03-28 13:02:55 UTC) #11
haraken
LGTM
3 years, 8 months ago (2017-03-28 15:57:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777223005/40001
3 years, 8 months ago (2017-03-28 16:09:12 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 16:56:10 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/037cd106d24d8205c8a076a18401...

Powered by Google App Engine
This is Rietveld 408576698