Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2777223002: Gets chrome --mus some what working (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gets chrome --mus some what working This makes chrome work in --mus mode. It comes up and displays stuff, but I have no doubt a bunch of stuff doesn't work. BUG=704985, 705592, 705595, 705591, 678949 TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2777223002 Cr-Commit-Position: refs/heads/master@{#459875} Committed: https://chromium.googlesource.com/chromium/src/+/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -107 lines) Patch
M ash/aura/wm_shell_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/common/wm_shell.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 4 chunks +8 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 6 chunks +18 lines, -2 lines 0 comments Download
M ash/mus/test/wm_test_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/mus/window_manager.h View 5 chunks +16 lines, -5 lines 0 comments Download
M ash/mus/window_manager.cc View 5 chunks +15 lines, -5 lines 0 comments Download
M ash/mus/window_manager_application.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ash/public/cpp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ash/public/cpp/config.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
M ash/shell.h View 3 chunks +5 lines, -1 line 0 comments Download
M ash/shell.cc View 7 chunks +21 lines, -6 lines 0 comments Download
M ash/test/ash_test_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ash_config.h View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ash_config.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 6 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.h View 1 chunk +18 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 5 chunks +66 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/ash_util.h View 3 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/ui/ash/ash_util.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 1 2 3 chunks +40 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/native_browser_frame_factory_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/mus/window_manager_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
sky
3 years, 8 months ago (2017-03-27 20:08:49 UTC) #7
Elliot Glaysher
lgtm
3 years, 8 months ago (2017-03-27 20:30:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777223002/40001
3 years, 8 months ago (2017-03-27 20:33:04 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-27 20:58:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/494c6cbdea529cc6aa1e4e344bdc...

Powered by Google App Engine
This is Rietveld 408576698