Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2777203005: Separate module byte size counter for asm.js/wasm. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Separate module byte size counter for asm.js/wasm. Currently, V8 uses the same size counter to measure module sizes for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when decoding. BUG=chromium:704922 R=mtrofin@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2777203005 Cr-Commit-Position: refs/heads/master@{#44211} Committed: https://chromium.googlesource.com/v8/v8/+/4e3f4b2d121dc9c77a880b16f82a1af277a23a27

Patch Set 1 #

Patch Set 2 : Fix conflicts due to merge. #

Patch Set 3 : Remove files that shouldn't be in CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/counters.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/wasm/module-decoder.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
kschimpf
Please review. Thanks!
3 years, 8 months ago (2017-03-28 15:46:30 UTC) #5
bradnelson
lgtm
3 years, 8 months ago (2017-03-28 18:19:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777203005/1
3 years, 8 months ago (2017-03-28 18:20:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37880)
3 years, 8 months ago (2017-03-28 18:23:30 UTC) #12
kschimpf
Accidentally committed some temporary files in patch set 2. Removed in patch set 3.
3 years, 8 months ago (2017-03-28 21:42:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777203005/40001
3 years, 8 months ago (2017-03-28 21:43:02 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 22:09:20 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/4e3f4b2d121dc9c77a880b16f82a1af277a...

Powered by Google App Engine
This is Rietveld 408576698