Issue 2777163003: Remember User locked rotation

Issue 2777163003: Remember User locked rotation (Closed)

Created:
3 years, 8 months ago by oshima

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, kalyank, sadrul, oshima+watch_chromium.org

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Remember User locked rotation * Save when the toggle state changes, as that's only time the value changes. * implement reverse lock. BUG=695281, 683456 TEST=manual, covered by unit test Review-Url: https://codereview.chromium.org/2773013003 Cr-Commit-Position: refs/heads/master@{#459502} (cherry picked from commit 28bd8173b80ae1fe5e22875580051664cd97363d) (cherry picked from commit ffb46dd77d7c4702110bf9dd6f3a9d35f70b41e5) Review-Url: https://codereview.chromium.org/2777163003 . Cr-Commit-Position: refs/branch-heads/3029@{#437} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/18462f6c9998579452ba3f6531170f8bb14f38c1

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+320 lines, -58 lines)			Patch
M	ash/display/display_manager_unittest.cc	View	2 chunks	+206 lines, -0 lines	0 comments	Download
M	ash/display/screen_orientation_controller_chromeos.cc	View	7 chunks	+112 lines, -58 lines	0 comments	Download
M	ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

oshima

3 years, 8 months ago (2017-03-27 19:35:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18462f6c9998579452ba3f6531170f8bb14f38c1.