Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2777163002: Make codegen and optimizations depend more directly on data objects. (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make codegen and optimizations depend more directly on data objects. This is a move towards passing all information through data objects computed by previous phases rather than pulling it directly from Backend or Compiler. This is needed to support a shift from model K to model J between resolution and codegen. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/e7a72961c823fa8a5cf18f36ee4fdfba71e08079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+564 lines, -346 lines) Patch
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 11 chunks +20 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 8 chunks +18 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 38 chunks +300 lines, -92 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 56 chunks +196 lines, -180 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 5 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/variable_allocator.dart View 6 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-27 14:12:19 UTC) #2
Emily Fortuna
lgtm. exciting!
3 years, 8 months ago (2017-03-27 17:51:24 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-03-28 08:38:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7a72961c823fa8a5cf18f36ee4fdfba71e08079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698