Make codegen and optimizations depend more directly on data objects.

pkg/compiler/lib/src/ssa/interceptor_simplifier.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import '../common/backend_api.dart' show BackendClasses;
-import '../compiler.dart' show Compiler;
 import '../constants/constant_system.dart';
 import '../constants/values.dart';
 import '../elements/entities.dart';
-import '../js_backend/backend.dart';
+import '../js_backend/backend_helpers.dart';
+import '../js_backend/interceptor_data.dart';
 import '../types/types.dart';
 import '../universe/selector.dart' show Selector;
 import '../world.dart' show ClosedWorld;
 import 'nodes.dart';
 import 'optimize.dart';
 
 /**
  * This phase simplifies interceptors in multiple ways:
  *
  * 1) If the interceptor is for an object whose type is known, it
@@ skipping 10 matching lines @@
  * receiver of an intercepted call a candidate for being generated at use site.
  *
  * 5) Some HIs operations on an interceptor are replaced with a HIs version that
  * uses 'instanceof' rather than testing a type flag.
  *
  */
 class SsaSimplifyInterceptors extends HBaseVisitor
     implements OptimizationPhase {
   final String name = "SsaSimplifyInterceptors";
   final ClosedWorld closedWorld;
-  final Compiler compiler;
+  final BackendHelpers helpers;
+  final InterceptorData interceptorData;
   final ClassEntity enclosingClass;
   HGraph graph;
 
-  SsaSimplifyInterceptors(this.compiler, this.closedWorld, this.enclosingClass);
-
-  JavaScriptBackend get backend => compiler.backend;
+  SsaSimplifyInterceptors(this.closedWorld, this.helpers, this.interceptorData,
+      this.enclosingClass);
 
   BackendClasses get backendClasses => closedWorld.backendClasses;
 
   ConstantSystem get constantSystem => closedWorld.constantSystem;
 
   void visitGraph(HGraph graph) {
     this.graph = graph;
     visitDominatorTree(graph);
   }
 
@@ skipping 43 matching lines @@
       return false;
     }
     if (receiver.canBeNull() &&
         interceptedClasses.contains(backendClasses.nullClass)) {
       // Need the JSNull interceptor.
       return false;
     }
 
     // All intercepted classes extend `Interceptor`, so if the receiver can't be
     // a class extending `Interceptor` then it can be called directly.
-    return new TypeMask.nonNullSubclass(
-            backend.helpers.jsInterceptorClass, closedWorld)
+    return new TypeMask.nonNullSubclass(helpers.jsInterceptorClass, closedWorld)
         .isDisjoint(receiver.instructionType, closedWorld);
   }
 
   HInstruction tryComputeConstantInterceptor(
       HInstruction input, Set<ClassEntity> interceptedClasses) {
     if (input == graph.explicitReceiverParameter) {
       // If `explicitReceiverParameter` is set it means the current method is an
       // interceptor method, and `this` is the interceptor.  The caller just did
       // `getInterceptor(foo).currentMethod(foo)` to enter the current method.
       return graph.thisInstruction;
@@ skipping 94 matching lines @@
         user.inputs.where((input) => input == used).length;
 
     Set<ClassEntity> interceptedClasses;
     HInstruction dominator = findDominator(node.usedBy);
     // If there is a call that dominates all other uses, we can use just the
     // selector of that instruction.
     if (dominator is HInvokeDynamic &&
         dominator.isCallOnInterceptor(closedWorld) &&
         node == dominator.receiver &&
         useCount(dominator, node) == 1) {
-      interceptedClasses = backend.interceptorData
-          .getInterceptedClassesOn(dominator.selector.name);
+      interceptedClasses =
+          interceptorData.getInterceptedClassesOn(dominator.selector.name);
 
       // If we found that we need number, we must still go through all
       // uses to check if they require int, or double.
       if (interceptedClasses.contains(backendClasses.numClass) &&
           !(interceptedClasses.contains(backendClasses.doubleClass) ||
               interceptedClasses.contains(backendClasses.intClass))) {
         Set<ClassEntity> required;
         for (HInstruction user in node.usedBy) {
           if (user is! HInvoke) continue;
-          Set<ClassEntity> intercepted = backend.interceptorData
-              .getInterceptedClassesOn(user.selector.name);
+          Set<ClassEntity> intercepted =
+              interceptorData.getInterceptedClassesOn(user.selector.name);
           if (intercepted.contains(backendClasses.intClass)) {
             // TODO(johnniwinther): Use type argument when all uses of
             // intercepted classes expect entities instead of elements.
             required ??= new Set/*<ClassEntity>*/();
             required.add(backendClasses.intClass);
           }
           if (intercepted.contains(backendClasses.doubleClass)) {
             // TODO(johnniwinther): Use type argument when all uses of
             // intercepted classes expect entities instead of elements.
             required ??= new Set/*<ClassEntity>*/();
             required.add(backendClasses.doubleClass);
           }
         }
-        // Don't modify the result of [backend.getInterceptedClassesOn].
+        // Don't modify the result of [interceptorData.getInterceptedClassesOn].
         if (required != null) {
           interceptedClasses = interceptedClasses.union(required);
         }
       }
     } else {
       // TODO(johnniwinther): Use type argument when all uses of intercepted
       // classes expect entities instead of elements.
       interceptedClasses = new Set/*<ClassEntity>*/();
       for (HInstruction user in node.usedBy) {
         if (user is HInvokeDynamic &&
             user.isCallOnInterceptor(closedWorld) &&
             node == user.receiver &&
             useCount(user, node) == 1) {
-          interceptedClasses.addAll(backend.interceptorData
-              .getInterceptedClassesOn(user.selector.name));
+          interceptedClasses.addAll(
+              interceptorData.getInterceptedClassesOn(user.selector.name));
         } else if (user is HInvokeSuper &&
             user.isCallOnInterceptor(closedWorld) &&
             node == user.receiver &&
             useCount(user, node) == 1) {
-          interceptedClasses.addAll(backend.interceptorData
-              .getInterceptedClassesOn(user.selector.name));
+          interceptedClasses.addAll(
+              interceptorData.getInterceptedClassesOn(user.selector.name));
         } else {
           // Use a most general interceptor for other instructions, example,
           // is-checks and escaping interceptors.
-          interceptedClasses.addAll(backend.interceptorData.interceptedClasses);
+          interceptedClasses.addAll(interceptorData.interceptedClasses);
           break;
         }
       }
     }
 
     node.interceptedClasses = interceptedClasses;
 
     HInstruction receiver = node.receiver;
 
     // TODO(sra): We should consider each use individually and then all uses
@@ skipping 56 matching lines @@
       block.addAfter(user, replacement);
       block.rewrite(user, replacement);
       block.remove(user);
       return false;
     }
 
     if (user is HIs) {
       // See if we can rewrite the is-check to use 'instanceof', i.e. rewrite
       // "getInterceptor(x).$isT" to "x instanceof T".
       if (node == user.interceptor) {
-        if (backend.interceptorData
-            .mayGenerateInstanceofCheck(user.typeExpression)) {
+        if (interceptorData.mayGenerateInstanceofCheck(user.typeExpression)) {
           HInstruction instanceofCheck = new HIs.instanceOf(
               user.typeExpression, user.expression, user.instructionType);
           instanceofCheck.sourceInformation = user.sourceInformation;
           instanceofCheck.sourceElement = user.sourceElement;
           return replaceUserWith(instanceofCheck);
         }
       }
     } else if (user is HInvokeDynamic) {
       if (node == user.inputs[0]) {
         // Replace the user with a [HOneShotInterceptor].
@@ skipping 56 matching lines @@
       instruction = new HInvokeDynamicMethod(
           selector, mask, inputs, node.instructionType, true);
     }
 
     HBasicBlock block = node.block;
     block.addAfter(node, instruction);
     block.rewrite(node, instruction);
     return true;
   }
 }