Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2777153002: move synthetic fasta closers into the token stream (Closed)

Created:
3 years, 9 months ago by danrubel
Modified:
3 years, 8 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Paul Berry
Target Ref:
refs/heads/master
Visibility:
Public.

Description

move synthetic fasta closers into the token stream * add new SyntheticSymbolToken class * whenever fasta inserts a closer ( '}', ']', ')' ) that is not part of the original source, ensure that the inserted closer is synthetic (isSynthetic returns true) and in the token stream * make EOF a synthetic token R=ahe@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/4a783d14654219b97d0e0698a50a7f539302084b

Patch Set 1 #

Patch Set 2 : cleanup imports #

Patch Set 3 : rebase and cleanup tests #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -89 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 2 chunks +1 line, -52 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 1 2 4 chunks +54 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 3 chunks +23 lines, -6 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 1 2 2 chunks +57 lines, -0 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 1 2 6 chunks +159 lines, -24 lines 0 comments Download
M pkg/front_end/test/scanner_test.dart View 1 2 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 9 months ago (2017-03-27 13:47:39 UTC) #2
scheglov
lgtm
3 years, 9 months ago (2017-03-27 14:00:07 UTC) #3
ahe
lgtm Don't forget to run dart2js unit tests on this, in particular tests/compiler/dart2js/message_kind_test.dart. This test ...
3 years, 9 months ago (2017-03-27 14:13:50 UTC) #4
danrubel
3 years, 8 months ago (2017-03-29 19:02:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
4a783d14654219b97d0e0698a50a7f539302084b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698