move synthetic fasta closers into the token stream

pkg/front_end/test/scanner_fasta_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/src/fasta/token_utils.dart';
 import 'package:front_end/src/fasta/scanner/error_token.dart' as fasta;
 import 'package:front_end/src/fasta/scanner/keyword.dart' as fasta;
 import 'package:front_end/src/fasta/scanner/string_scanner.dart' as fasta;
 import 'package:front_end/src/fasta/scanner/token.dart' as fasta;
 import 'package:front_end/src/fasta/scanner/token_constants.dart' as fasta;
@@ skipping 172 matching lines @@
           expect(commentToken.next.previousToken, commentToken);
         }
         commentToken = commentToken.next;
       }
       token = token.next;
     }
   }
 
   @override
   @failingTest
+  void test_incomplete_string_interpolation() {
+    // TODO(danrubel): fix ToAnalyzerTokenStreamConverter_WithListener
+    // to handle synthetic closers in token stream
+    super.test_incomplete_string_interpolation();
+  }
+
+  @override
+  void test_mismatched_opener_in_interpolation() {
+    // When openers and closers are mismatched,
+    // fasta favors considering the opener to be mismatched
+    // and inserts synthetic closers as needed.
+    // r'"${({(}}"' is parsed as r'"${({()})}"'
+    // where both ')' are synthetic
+    var stringStart = _scan(r'"${({(}}"');
+    var interpolationStart = stringStart.next as BeginToken;
+    var openParen1 = interpolationStart.next as BeginToken;
+    var openBrace = openParen1.next as BeginToken;
+    var openParen2 = openBrace.next as BeginToken;
+    var closeParen2 = openParen2.next;
+    var closeBrace = closeParen2.next;
+    var closeParen1 = closeBrace.next;
+    var interpolationEnd = closeParen1.next;
+    var stringEnd = interpolationEnd.next;
+    expect(stringEnd.next.type, TokenType.EOF);
+    expect(interpolationStart.endToken, same(interpolationEnd));
+    expect(openParen1.endToken, same(closeParen1));
+    expect(openBrace.endToken, same(closeBrace));
+    expect(openParen2.endToken, same(closeParen2));
+  }
+
+  @override
+  @failingTest
   void test_string_multi_unterminated() {
     // TODO(paulberry,ahe): bad error recovery.
     super.test_string_multi_unterminated();
   }
 
   @override
   @failingTest
   void test_string_multi_unterminated_interpolation_block() {
     // TODO(paulberry,ahe): bad error recovery.
     super.test_string_multi_unterminated_interpolation_block();
@@ skipping 47 matching lines @@
     // TODO(paulberry,ahe): bad error recovery.
     super.test_string_simple_unterminated_interpolation_block();
   }
 
   @override
   @failingTest
   void test_string_simple_unterminated_interpolation_identifier() {
     // TODO(paulberry,ahe): bad error recovery.
     super.test_string_simple_unterminated_interpolation_identifier();
   }
+
+  @override
+  void test_unmatched_openers() {
+    var openBrace = _scan('{[(') as BeginToken;
+    var openBracket = openBrace.next as BeginToken;
+    var openParen = openBracket.next as BeginToken;
+    var closeParen = openParen.next;
+    var closeBracket = closeParen.next;
+    var closeBrace = closeBracket.next;
+    expect(closeBrace.next.type, TokenType.EOF);
+    expect(openBrace.endToken, same(closeBrace));
+    expect(openBracket.endToken, same(closeBracket));
+    expect(openParen.endToken, same(closeParen));
+  }
+
+  Token _scan(String source,
+      {bool genericMethodComments: false,
+      bool lazyAssignmentOperators: false}) {
+    ErrorListener listener = new ErrorListener();
+    Token token = scanWithListener(source, listener,
+        genericMethodComments: genericMethodComments,
+        lazyAssignmentOperators: lazyAssignmentOperators);
+    listener.assertNoErrors();
+    return token;
+  }
 }
 
 /// Base class for scanner tests that examine the token stream in Fasta format.
 abstract class ScannerTest_Fasta_Base {
   fasta.Token scan(String source);
 
   void test_match_angle_brackets() {
     var x = scan('x<y>');
     var lessThan = x.next as fasta.BeginGroupToken;
     var y = lessThan.next;
@@ skipping 189 matching lines @@
   final ErrorListener _listener;
 
   ToAnalyzerTokenStreamConverter_WithListener(this._listener);
 
   @override
   void reportError(
       ScannerErrorCode errorCode, int offset, List<Object> arguments) {
     _listener.errors.add(new TestError(offset, errorCode, arguments));
   }
 }