Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2777143002: Initialize WakeLockContextHost lazily (Closed)

Created:
3 years, 9 months ago by blundell
Modified:
3 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize WakeLockContextHost lazily Most WebContents instances won't need it. BUG=689403 TEST=On Chrome on Android, go to about://flags and turn on "Experimental Web Platform features." Restart Chrome. Go to https://colinblundell.github.io/wake_lock.html and verify that the page says "Wake Lock API found". Verify that if you wait ~40 seconds, the device goes to sleep. Tap "Block sleep." Verify that if you wait longer than the above period, the device does not go to sleep. Tap "Unblock sleep" and verify again that the device goes to sleep after waiting. Review-Url: https://codereview.chromium.org/2777143002 Cr-Commit-Position: refs/heads/master@{#460035} Committed: https://chromium.googlesource.com/chromium/src/+/d8cd72b77ad75432b531dd5d2c5d866544a2240c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
blundell
3 years, 9 months ago (2017-03-27 14:23:39 UTC) #4
jam
lgtm
3 years, 9 months ago (2017-03-27 20:01:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777143002/1
3 years, 9 months ago (2017-03-28 07:13:30 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 07:19:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8cd72b77ad75432b531dd5d2c5d...

Powered by Google App Engine
This is Rietveld 408576698