Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2777103005: Using WmDisplayObserver in ScreenPinningController. (Closed)

Created:
3 years, 8 months ago by Peng
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Using WmDisplayObserver in ScreenPinningController. BUG=705702 Review-Url: https://codereview.chromium.org/2777103005 Cr-Commit-Position: refs/heads/master@{#460169} Committed: https://chromium.googlesource.com/chromium/src/+/65976c977c5695514909ff1cebe30e2dd6c2c60c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M ash/shell.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/wm/screen_pinning_controller.h View 5 chunks +4 lines, -11 lines 0 comments Download
M ash/wm/screen_pinning_controller.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Peng
Hi Scott, PTAL. Thanks.
3 years, 8 months ago (2017-03-28 15:31:03 UTC) #6
sky
Nice! Thanks LGTM
3 years, 8 months ago (2017-03-28 17:30:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777103005/1
3 years, 8 months ago (2017-03-28 18:00:57 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 18:08:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65976c977c5695514909ff1cebe3...

Powered by Google App Engine
This is Rietveld 408576698