Chromium Code Reviews| Index: build/android/test_runner.py |
| diff --git a/build/android/test_runner.py b/build/android/test_runner.py |
| index deacc6c07370160db9d154cfc330fae741a0af24..cb2767e662415d00f49b3341f9a0109ec415c47d 100755 |
| --- a/build/android/test_runner.py |
| +++ b/build/android/test_runner.py |
| @@ -756,6 +756,10 @@ def RunTestsInPlatformMode(args): |
| dst = logdog_helper.open_text('unified_logcats') |
|
jbudorick
2017/03/28 01:09:21
hrm, should this be
with logdog_helper.text('un
mikecase (-- gone --)
2017/03/28 15:39:51
logdog_helper.text isnt a contextmanager. So that
jbudorick
2017/03/28 15:41:27
ah, my mistake. I was looking at the underlying cl
|
| if dst: |
| shutil.copyfileobj(src, dst) |
| + dst.close() |
| + logging.critical( |
| + 'Logcat: %s', logdog_helper.get_viewer_url('unified_logcats')) |
| + |
| logcats_uploader = contextlib_ext.Optional( |
| upload_logcats_file(), |