Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message (Closed)
Patch Set: Readd the extra_process_dump map Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
diff --git a/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
index 3cdba345a4bd17a33909c9f99c7603346f5fad5a..12244c62ba2215a2416e2f32dd6cbb4374d5ae19 100644
--- a/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
+++ b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
@@ -22,12 +22,29 @@ struct RequestArgs {
LevelOfDetail level_of_detail;
};
+struct OSMemDump {
+ uint32 resident_set_kb = 0;
+};
+
+struct ChromeMemDump {
+ uint32 malloc_total_kb = 0;
+ uint32 partition_alloc_total_kb = 0;
hjd 2017/04/06 11:18:45 Maybe our structs should be uint64? uint32 only go
Primiano Tucci (use gerrit) 2017/04/07 15:31:37 I'd hope they do suffice, if we go over 4TB we hav
fmeawad 2017/04/10 20:20:19 Happy to make the change on both side if we decide
+ uint32 blink_gc_total_kb = 0;
+ uint32 v8_total_kb = 0;
+};
+
+struct MemoryDumpCallbackResult {
+ OSMemDump os_dump;
+ ChromeMemDump chrome_dump;
hjd 2017/04/06 11:18:45 With the map to be added in a follow up?
Primiano Tucci (use gerrit) 2017/04/07 15:31:37 given the cl description I guess so .)
fmeawad 2017/04/10 20:20:19 Yes.
+};
+
// There should be at most one implementation of this interface per process.
interface ProcessLocalDumpManager {
// When successful, the dump is appended in the process-local trace buffer of
- // the target process and only an ACK is returned.
+ // the target process and an ACK. A summary of the dump is also returned in
+ // case of success.
RequestProcessMemoryDump(RequestArgs args) =>
- (uint64 dump_guid, bool success);
+ (uint64 dump_guid, bool success, MemoryDumpCallbackResult? result);
};
// Memory Infra service implements this interface. ProcessLocalDumpManagers

Powered by Google App Engine
This is Rietveld 408576698