Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2777073003: Split counters for functions per module for asm and wasm. (Closed)

Created:
3 years, 9 months ago by kschimpf
Modified:
3 years, 9 months ago
Reviewers:
bbudge, bradnelson
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Split counters for functions per module for asm and wasm. Currently, V8 uses the same counter to count both wasm and and asm js. This splits the counters into two separate counters, and then uses the appropriate counter when instantiating the module. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2777073003 Cr-Commit-Position: refs/heads/master@{#44164} Committed: https://chromium.googlesource.com/v8/v8/+/35701006960e4a6419f2dcb62964cfbb311bcd5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/counters.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
kschimpf
3 years, 9 months ago (2017-03-27 20:30:03 UTC) #9
bradnelson
lgtm
3 years, 9 months ago (2017-03-27 20:43:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777073003/1
3 years, 9 months ago (2017-03-27 21:08:24 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 21:09:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/35701006960e4a6419f2dcb62964cfbb311...

Powered by Google App Engine
This is Rietveld 408576698