Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2777063009: Generate list of Chrome OS device polices (Closed)

Created:
3 years, 8 months ago by ljusten (tachyonic)
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate list of Chrome OS device polices Modifies the script that generates code from policy_templates.json to output a list of all supported device policies. The code is not used in Chromium. It will be used in Chrome OS's authpolicy project in order to make sure that its code to encode a device policy protobuf handles all device policies. BUG=659101 TEST=Compiled Chromium, tested autogenerated code in Chrome OS Review-Url: https://codereview.chromium.org/2777063009 Cr-Commit-Position: refs/heads/master@{#461088} Committed: https://chromium.googlesource.com/chromium/src/+/ccd75912ceea7ff6171e35e7b98bdfb618b9265f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M components/policy/tools/generate_policy_source.py View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ljusten (tachyonic)
Hey Maksim, this is a small addition to the last CL you've reviewed for me. ...
3 years, 8 months ago (2017-03-29 16:50:00 UTC) #2
emaxx
On 2017/03/29 16:50:00, ljusten wrote: > Hey Maksim, this is a small addition to the ...
3 years, 8 months ago (2017-03-29 23:12:09 UTC) #3
ljusten (tachyonic)
On 2017/03/29 23:12:09, emaxx wrote: > On 2017/03/29 16:50:00, ljusten wrote: > > Hey Maksim, ...
3 years, 8 months ago (2017-03-30 07:22:55 UTC) #4
ljusten (tachyonic)
Hey Drew, could you check this please? Thanks!
3 years, 8 months ago (2017-03-30 07:24:08 UTC) #6
Andrew T Wilson (Slow)
lgtm
3 years, 8 months ago (2017-03-31 07:24:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777063009/1
3 years, 8 months ago (2017-03-31 08:30:53 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 09:34:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ccd75912ceea7ff6171e35e7b98b...

Powered by Google App Engine
This is Rietveld 408576698