Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2777063007: Corrected specificity for :not for default @namespace. (Closed)

Created:
3 years, 8 months ago by rune
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Corrected specificity for :not for default @namespace. The argument to :not() consists of a universal, type, or a simple selector. However, we prepend an implicit universal selector with the default namespace URI to all compound selectors to correctly match only elements in the default namespace. That is not necessary for compounds inside pseudo argument lists, but we do in those cases as well. When calculating the specificity for :not(), we assume its argument consists of a single simple selectors, but in the case where we have a default namespace, a namespaced universal selector is prepended. We only added the specificity for the universal selector in that case. Instead, walk all sub-selectors of the :not() compound when calculating the specificity. R=meade@chromium.org BUG=706206 Review-Url: https://codereview.chromium.org/2777063007 Cr-Commit-Position: refs/heads/master@{#460355} Committed: https://chromium.googlesource.com/chromium/src/+/76f8029bef50611fdddf565925b9420bdac05021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/specificity-not-and-default-ns.html View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
rune
ptal
3 years, 8 months ago (2017-03-28 23:59:59 UTC) #1
meade_UTC10
lgtm
3 years, 8 months ago (2017-03-29 00:51:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777063007/1
3 years, 8 months ago (2017-03-29 09:42:12 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 11:43:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76f8029bef50611fdddf565925b9...

Powered by Google App Engine
This is Rietveld 408576698