Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7251)

Unified Diff: chrome/common/extensions/sync_type_unittest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Fix SupervisedUserWhitelistInstaller Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/sync_type_unittest.cc
diff --git a/chrome/common/extensions/sync_type_unittest.cc b/chrome/common/extensions/sync_type_unittest.cc
index 2ac283b45aabe0cba493cf9b1a6f0dec1b9a004f..e4c5d3060ce100f22d1661d2917f19c38875e578 100644
--- a/chrome/common/extensions/sync_type_unittest.cc
+++ b/chrome/common/extensions/sync_type_unittest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
jdoerrie 2017/04/06 14:25:51 #include <utility>
vabr (Chromium) 2017/04/07 20:40:41 Done.
#include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
#include "build/build_config.h"
#include "chrome/common/extensions/api/plugins/plugins_handler.h"
#include "chrome/common/extensions/sync_helper.h"
@@ -56,16 +57,16 @@ class ExtensionSyncTypeTest : public testing::Test {
if (num_plugins >= 0) {
base::ListValue* plugins = new base::ListValue();
for (int i = 0; i < num_plugins; ++i) {
- base::DictionaryValue* plugin = new base::DictionaryValue();
+ auto plugin = base::MakeUnique<base::DictionaryValue>();
plugin->SetString(keys::kPluginsPath, std::string());
- plugins->Set(i, plugin);
+ plugins->Set(i, std::move(plugin));
}
source.Set(keys::kPlugins, plugins);
}
}
if (has_plugin_permission) {
base::ListValue* plugins = new base::ListValue();
- plugins->Set(0, new base::Value("plugin"));
+ plugins->Set(0, base::MakeUnique<base::Value>("plugin"));
source.Set(keys::kPermissions, plugins);
}

Powered by Google App Engine
This is Rietveld 408576698