Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/prefs/tracked/pref_hash_browsertest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Fix SupervisedUserWhitelistInstaller Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/tracked/pref_hash_browsertest.cc
diff --git a/chrome/browser/prefs/tracked/pref_hash_browsertest.cc b/chrome/browser/prefs/tracked/pref_hash_browsertest.cc
index 513998b727f277aae996165a606ddf5b53dd2be5..3ce0b097160f89a6bcb17c9fd7246a6456237141 100644
--- a/chrome/browser/prefs/tracked/pref_hash_browsertest.cc
+++ b/chrome/browser/prefs/tracked/pref_hash_browsertest.cc
@@ -885,9 +885,9 @@ class PrefHashBrowserTestChangedSplitPref : public PrefHashBrowserTestBase {
// Drop a fake extension (for the purpose of this test, dropped settings
// don't need to be valid extension settings).
- base::DictionaryValue* fake_extension = new base::DictionaryValue;
+ auto fake_extension = base::MakeUnique<base::DictionaryValue>();
fake_extension->SetString("name", "foo");
- extensions_dict->Set(std::string(32, 'a'), fake_extension);
+ extensions_dict->Set(std::string(32, 'a'), std::move(fake_extension));
}
void VerifyReactionToPrefAttack() override {

Powered by Google App Engine
This is Rietveld 408576698