Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2777013006:
MD Settings: Prevent erroneous scroll when navigating subpage->subpage. (Closed)
|
Created:
3 years, 8 months ago by tommycli Modified:
3 years, 8 months ago Reviewers:
michaelpg CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Prevent erroneous scroll when navigating subpage->subpage.
Currently, when collapsing a section, to another route that is part of
a section, we scroll to the new section.
This is not desirable for direct subpage->subpage navigations. This CL
limits that scroll behavior to only when navigating to a section route
(and not when navigating to a subpage route).
BUG=705927
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2777013006
Cr-Commit-Position: refs/heads/master@{#460594}
Committed: https://chromium.googlesource.com/chromium/src/+/ab92320fc8387be1c91c221223d7c632875a90b4
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comment #Messages
Total messages: 19 (12 generated)
Description was changed from ========== MD Settings: Prevent erroneous scroll when navigating subpage->subpage. Currently, when collapsing a section, to another route that is part of a section, we scroll to the new section. This is not desirable for direct subpage->subpage navigations. This CL limits that scroll behavior to only when navigating to a section route (and not when navigating to a subpage route). BUG=705927 ========== to ========== MD Settings: Prevent erroneous scroll when navigating subpage->subpage. Currently, when collapsing a section, to another route that is part of a section, we scroll to the new section. This is not desirable for direct subpage->subpage navigations. This CL limits that scroll behavior to only when navigating to a section route (and not when navigating to a subpage route). BUG=705927 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
tommycli@chromium.org changed reviewers: + michaelpg@chromium.org
michaelpg: PTAL, thanks!
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm w/ suggestion https://codereview.chromium.org/2777013006/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2777013006/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/main_page_behavior.js:290: !settings.getCurrentRoute().isSubpage() && I think this would be clearer as part of the "if" below, i.e. in the same check as !wasPopState. |newSection| is just storing the current section which is "correct" either way.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
thanks! https://codereview.chromium.org/2777013006/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2777013006/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/main_page_behavior.js:290: !settings.getCurrentRoute().isSubpage() && On 2017/03/29 01:11:21, michaelpg wrote: > I think this would be clearer as part of the "if" below, i.e. in the same check > as !wasPopState. |newSection| is just storing the current section which is > "correct" either way. Done.
The CQ bit was checked by tommycli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/2777013006/#ps20001 (title: "address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490825055907040,
"parent_rev": "be89630e7a0493ea501968766d8e30e3a00db3b1", "commit_rev":
"ab92320fc8387be1c91c221223d7c632875a90b4"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Prevent erroneous scroll when navigating subpage->subpage. Currently, when collapsing a section, to another route that is part of a section, we scroll to the new section. This is not desirable for direct subpage->subpage navigations. This CL limits that scroll behavior to only when navigating to a section route (and not when navigating to a subpage route). BUG=705927 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Prevent erroneous scroll when navigating subpage->subpage. Currently, when collapsing a section, to another route that is part of a section, we scroll to the new section. This is not desirable for direct subpage->subpage navigations. This CL limits that scroll behavior to only when navigating to a section route (and not when navigating to a subpage route). BUG=705927 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2777013006 Cr-Commit-Position: refs/heads/master@{#460594} Committed: https://chromium.googlesource.com/chromium/src/+/ab92320fc8387be1c91c221223d7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ab92320fc8387be1c91c221223d7... |
