Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2777013005: Moving IChildProcessService to base/ (Closed)

Created:
3 years, 8 months ago by Jay Civelli
Modified:
3 years, 8 months ago
Reviewers:
palmer, nyquist, boliu
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving IChildProcessService to base/ As part of the effort of moving Android process launching to base/, moving IChildProcessService.aidl to base/. BUG=702316 Review-Url: https://codereview.chromium.org/2777013005 Cr-Commit-Position: refs/heads/master@{#461020} Committed: https://chromium.googlesource.com/chromium/src/+/ce6ef2968b6785ccc8c29bf8b5954b5242845552

Patch Set 1 : Moving IChildProcessService to base/ #

Total comments: 2

Messages

Total messages: 38 (24 generated)
Jay Civelli
3 years, 8 months ago (2017-03-29 00:26:58 UTC) #15
boliu
lgtm https://codereview.chromium.org/2777013005/diff/20001/base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl File base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl (right): https://codereview.chromium.org/2777013005/diff/20001/base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl#newcode5 base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl:5: package org.chromium.base.process_launcher; are security owners set up for ...
3 years, 8 months ago (2017-03-29 01:07:02 UTC) #16
Jay Civelli
https://codereview.chromium.org/2777013005/diff/20001/base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl File base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl (right): https://codereview.chromium.org/2777013005/diff/20001/base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl#newcode5 base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl:5: package org.chromium.base.process_launcher; On 2017/03/29 01:07:01, boliu wrote: > are ...
3 years, 8 months ago (2017-03-29 16:12:17 UTC) #17
Jay Civelli
3 years, 8 months ago (2017-03-29 16:14:07 UTC) #18
Jay Civelli
Adding palmer@ for security review of AIDL changes.
3 years, 8 months ago (2017-03-29 16:14:49 UTC) #21
palmer
lgtm
3 years, 8 months ago (2017-03-30 01:25:54 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777013005/20001
3 years, 8 months ago (2017-03-30 01:44:17 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398299)
3 years, 8 months ago (2017-03-30 01:55:34 UTC) #26
Jay Civelli
Adding nyquist@ for base/android OWNERS review
3 years, 8 months ago (2017-03-30 03:28:11 UTC) #28
nyquist
lgtm
3 years, 8 months ago (2017-03-30 20:44:17 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777013005/20001
3 years, 8 months ago (2017-03-30 20:46:10 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/183828)
3 years, 8 months ago (2017-03-30 23:08:19 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777013005/20001
3 years, 8 months ago (2017-03-31 01:47:31 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 03:59:22 UTC) #38
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce6ef2968b6785ccc8c29bf8b595...

Powered by Google App Engine
This is Rietveld 408576698