Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2777013003: Construct an id for USB printers so it is stable across plugins and (Closed)

Created:
3 years, 8 months ago by Carlson
Modified:
3 years, 8 months ago
Reviewers:
skau
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Construct an id for USB printers so it is stable across plugins and can be appropriately synced with a users's printer list. BUG=705651 Review-Url: https://codereview.chromium.org/2777013003 Cr-Commit-Position: refs/heads/master@{#460164} Committed: https://chromium.googlesource.com/chromium/src/+/8e630828534715e0983ffbb0c964fde29bf6afbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M chrome/browser/chromeos/printing/usb_printer_util.cc View 3 chunks +62 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Carlson
3 years, 8 months ago (2017-03-27 20:04:22 UTC) #2
skau
Since you have a stable id now, do you want to change this call? https://cs.chromium.org/chromium/src/chrome/browser/chromeos/printer_detector/cups_printer_detector.cc?rcl=06be3b5e0202f6c0b4aa4fc331e74ceada3f18ba&l=117
3 years, 8 months ago (2017-03-28 01:18:26 UTC) #7
Carlson
On 2017/03/28 01:18:26, skau wrote: > Since you have a stable id now, do you ...
3 years, 8 months ago (2017-03-28 16:05:51 UTC) #8
skau
lgtm
3 years, 8 months ago (2017-03-28 17:39:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777013003/1
3 years, 8 months ago (2017-03-28 17:47:53 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:58:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e630828534715e0983ffbb0c964...

Powered by Google App Engine
This is Rietveld 408576698